From: Florian Fainelli <florian.fainelli@broadcom.com>
To: linux-kernel@vger.kernel.org
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Kieran Bingham <kbingham@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Shanker Donthineni <sdonthineni@nvidia.com>
Subject: [PATCH] scripts/gdb: Fix interrupts.py after maple tree conversion
Date: Fri, 20 Jun 2025 11:14:46 -0700 [thread overview]
Message-ID: <20250620181446.477246-1-florian.fainelli@broadcom.com> (raw)
In commit 721255b9826b ("genirq: Use a maple tree for interrupt
descriptor management"), the irq_desc_tree was replaced with a
sparse_irqs tree using a maple tree structure. In the interest of
providing both a minimal bugfix as well as something that is unlikely to
break in the future, invoke the irq_to_desc() function directly from
within GDB in order to obtain the interrupt number. This requires us to
handle the gdb.error exception to continue walking the tree.
Fixes: 721255b9826b ("genirq: Use a maple tree for interrupt descriptor management")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
scripts/gdb/linux/interrupts.py | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/scripts/gdb/linux/interrupts.py b/scripts/gdb/linux/interrupts.py
index 616a5f26377a..81bfa09f45fb 100644
--- a/scripts/gdb/linux/interrupts.py
+++ b/scripts/gdb/linux/interrupts.py
@@ -7,7 +7,6 @@ import gdb
from linux import constants
from linux import cpus
from linux import utils
-from linux import radixtree
irq_desc_type = utils.CachedType("struct irq_desc")
@@ -23,12 +22,11 @@ def irqd_is_level(desc):
def show_irq_desc(prec, irq):
text = ""
- desc = radixtree.lookup(gdb.parse_and_eval("&irq_desc_tree"), irq)
- if desc is None:
- return text
-
- desc = desc.cast(irq_desc_type.get_type())
- if desc is None:
+ try:
+ desc = gdb.parse_and_eval(f"irq_to_desc({irq})")
+ if desc == 0:
+ return text
+ except gdb.error:
return text
if irq_settings_is_hidden(desc):
@@ -221,7 +219,7 @@ class LxInterruptList(gdb.Command):
gdb.write("CPU%-8d" % cpu)
gdb.write("\n")
- if utils.gdb_eval_or_none("&irq_desc_tree") is None:
+ if utils.gdb_eval_or_none("&irq_desc_tree") or utils.gdb_eval_or_none("&sparse_irqs") is None:
return
for irq in range(nr_irqs):
--
2.43.0
next reply other threads:[~2025-06-20 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 18:14 Florian Fainelli [this message]
2025-06-20 18:26 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250620181446.477246-1-florian.fainelli@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=jan.kiszka@siemens.com \
--cc=kbingham@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sdonthineni@nvidia.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®