From: Joel Fernandes <joelagnelf@nvidia.com>
To: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>
Cc: Joel Fernandes <joelagnelf@nvidia.com>, Tejun Heo <tj@kernel.org>,
David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>
Subject: [PATCH v5 10/14] sched/deadline: Add support to remove DLserver's bandwidth contribution
Date: Fri, 20 Jun 2025 16:32:25 -0400 [thread overview]
Message-ID: <20250620203234.3349930-11-joelagnelf@nvidia.com> (raw)
In-Reply-To: <20250620203234.3349930-1-joelagnelf@nvidia.com>
From: Andrea Righi <arighi@nvidia.com>
During switching from sched_ext to FAIR tasks and vice-versa, we need
support for removing the bandwidth contribution of either DL server. Add
support for the same.
Co-developed-by: Joel Fernandes <joelagnelf@nvidia.com>
Signed-off-by: Andrea Righi <arighi@nvidia.com>
---
kernel/sched/deadline.c | 31 +++++++++++++++++++++++++++++++
kernel/sched/sched.h | 1 +
2 files changed, 32 insertions(+)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index c61752c2e052..50d938856b3d 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1742,6 +1742,12 @@ int dl_server_apply_params(struct sched_dl_entity *dl_se, u64 runtime, u64 perio
dl_rq_change_utilization(rq, dl_se, new_bw);
}
+ /* Clear these so that the dl_server is reinitialized */
+ if (new_bw == 0) {
+ dl_se->dl_defer = 0;
+ dl_se->dl_server = 0;
+ }
+
dl_se->dl_runtime = runtime;
dl_se->dl_deadline = period;
dl_se->dl_period = period;
@@ -1755,6 +1761,31 @@ int dl_server_apply_params(struct sched_dl_entity *dl_se, u64 runtime, u64 perio
return retval;
}
+/**
+ * dl_server_remove_params - Remove bandwidth reservation for a DL server
+ * @dl_se: The DL server entity to remove bandwidth for
+ *
+ * This function removes the bandwidth reservation for a DL server entity,
+ * cleaning up all bandwidth accounting and server state.
+ *
+ * Returns: 0 on success, negative error code on failure
+ */
+int dl_server_remove_params(struct sched_dl_entity *dl_se)
+{
+ if (!dl_se->dl_server)
+ return 0; /* Already disabled */
+
+ /*
+ * First dequeue if still queued. It should not be queued since
+ * we call this only after the last dl_server_stop().
+ */
+ if (WARN_ON_ONCE(on_dl_rq(dl_se)))
+ dequeue_dl_entity(dl_se, DEQUEUE_SLEEP);
+
+ /* Remove bandwidth reservation */
+ return dl_server_apply_params(dl_se, 0, dl_se->dl_period, false);
+}
+
/*
* Update the current task's runtime statistics (provided it is still
* a -deadline task and has not been removed from the dl_rq).
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 576b69cee6b1..13dc32a6346a 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -393,6 +393,7 @@ extern void ext_server_init(struct rq *rq);
extern void __dl_server_attach_root(struct sched_dl_entity *dl_se, struct rq *rq);
extern int dl_server_apply_params(struct sched_dl_entity *dl_se,
u64 runtime, u64 period, bool init);
+extern int dl_server_remove_params(struct sched_dl_entity *dl_se);
static inline bool dl_server_active(struct sched_dl_entity *dl_se)
{
--
2.43.0
next prev parent reply other threads:[~2025-06-20 20:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 20:32 [PATCH v5 00/14] Add a deadline server for sched_ext tasks Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 01/14] sched/debug: Fix updating of ppos on server write ops Joel Fernandes
2025-06-23 20:14 ` Tejun Heo
2025-06-20 20:32 ` [PATCH v5 02/14] sched/debug: Stop and start server based on if it was active Joel Fernandes
2025-06-23 20:16 ` Tejun Heo
2025-06-30 14:11 ` Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 03/14] sched/deadline: Clear the defer params Joel Fernandes
2025-06-23 20:17 ` Tejun Heo
2025-06-30 14:30 ` Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 04/14] sched/deadline: Prevent setting server as started if params couldn't be applied Joel Fernandes
2025-06-25 12:56 ` Juri Lelli
2025-06-30 14:45 ` Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 05/14] sched/deadline: Return EBUSY if dl_bw_cpus is zero Joel Fernandes
2025-06-23 20:20 ` Tejun Heo
2025-06-30 14:50 ` Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 06/14] sched: Add support to pick functions to take rf Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 07/14] sched: Add a server arg to dl_server_update_idle_time() Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 08/14] sched/ext: Add a DL server for sched_ext tasks Joel Fernandes
2025-06-23 22:11 ` Tejun Heo
2025-06-30 15:12 ` Joel Fernandes
2025-06-30 15:38 ` Tejun Heo
2025-07-01 13:23 ` Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 09/14] sched/debug: Add support to change sched_ext server params Joel Fernandes
2025-06-23 22:12 ` Tejun Heo
2025-06-30 15:26 ` Joel Fernandes
2025-06-20 20:32 ` Joel Fernandes [this message]
2025-06-20 20:32 ` [PATCH v5 11/14] sched/ext: Relinquish DL server reservations when not needed Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 12/14] selftests/sched_ext: Add test for sched_ext dl_server Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 13/14] sched/deadline: Fix DL server crash in inactive_timer callback Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 14/14] selftests/sched_ext: Add test for DL server total_bw consistency Joel Fernandes
2025-06-20 20:44 ` [PATCH v5 00/14] Add a deadline server for sched_ext tasks Joel Fernandes
2025-06-23 22:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250620203234.3349930-11-joelagnelf@nvidia.com \
--to=joelagnelf@nvidia.com \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®