From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Jason A . Donenfeld " <Jason@zx2c4.com>,
Ard Biesheuvel <ardb@kernel.org>,
Eric Biggers <ebiggers@kernel.org>
Subject: [PATCH] crypto: testmgr/sha512 - Omit generic_driver for no-op tests
Date: Fri, 20 Jun 2025 18:49:23 -0700 [thread overview]
Message-ID: <20250621014923.25064-1-ebiggers@kernel.org> (raw)
Some of the entries in alg_test_descs[] exist purely for the benefit of
marking the algorithm as "FIPS allowed", and they use a no-op test
function. These entries don't need generic_driver filled in.
Fixes: 50058ca36580 ("crypto: sha512 - Replace sha512_generic with wrapper around SHA-512 library")
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
I'm planned to fold this into the fixed commit, as this patch just
removes lines that commit added.
crypto/testmgr.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 9b4235adcb036..825a3a617f2a7 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -4318,11 +4318,10 @@ static const struct alg_test_desc alg_test_descs[] = {
.suite = {
.aead = __VECS(hmac_sha384_des3_ede_cbc_tv_temp)
}
}, {
.alg = "authenc(hmac(sha384),ctr(aes))",
- .generic_driver = "authenc(hmac-sha384-lib,ctr(aes-generic))",
.test = alg_test_null,
.fips_allowed = 1,
}, {
.alg = "authenc(hmac(sha384),cts(cbc(aes)))",
.generic_driver = "authenc(hmac-sha384-lib,cts(cbc(aes-generic)))",
@@ -4330,11 +4329,10 @@ static const struct alg_test_desc alg_test_descs[] = {
.suite = {
.aead = __VECS(krb5_test_aes256_cts_hmac_sha384_192)
}
}, {
.alg = "authenc(hmac(sha384),rfc3686(ctr(aes)))",
- .generic_driver = "authenc(hmac-sha384-lib,rfc3686(ctr(aes-generic)))",
.test = alg_test_null,
.fips_allowed = 1,
}, {
.alg = "authenc(hmac(sha512),cbc(aes))",
.generic_driver = "authenc(hmac-sha512-lib,cbc(aes-generic))",
@@ -4357,16 +4355,14 @@ static const struct alg_test_desc alg_test_descs[] = {
.suite = {
.aead = __VECS(hmac_sha512_des3_ede_cbc_tv_temp)
}
}, {
.alg = "authenc(hmac(sha512),ctr(aes))",
- .generic_driver = "authenc(hmac-sha512-lib,ctr(aes-generic))",
.test = alg_test_null,
.fips_allowed = 1,
}, {
.alg = "authenc(hmac(sha512),rfc3686(ctr(aes)))",
- .generic_driver = "authenc(hmac-sha512-lib,rfc3686(ctr(aes-generic)))",
.test = alg_test_null,
.fips_allowed = 1,
}, {
.alg = "blake2b-160",
.test = alg_test_hash,
@@ -5350,16 +5346,14 @@ static const struct alg_test_desc alg_test_descs[] = {
.alg = "pkcs1(rsa,sha3-512)",
.test = alg_test_null,
.fips_allowed = 1,
}, {
.alg = "pkcs1(rsa,sha384)",
- .generic_driver = "pkcs1(rsa,sha384-lib)",
.test = alg_test_null,
.fips_allowed = 1,
}, {
.alg = "pkcs1(rsa,sha512)",
- .generic_driver = "pkcs1(rsa,sha512-lib)",
.test = alg_test_null,
.fips_allowed = 1,
}, {
.alg = "pkcs1pad(rsa)",
.test = alg_test_null,
base-commit: c075093bd9493fb2032a2e1cbb3df4c03f92fa1f
--
2.50.0
reply other threads:[~2025-06-21 1:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250621014923.25064-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®