From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
westeri@kernel.org, YehezkelShB@gmail.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] thunderbolt: Fix redundant Bit masking of ADP_DP_CS_1_AUX_RX_HOPID_MASK
Date: Mon, 23 Jun 2025 12:55:31 +0300 [thread overview]
Message-ID: <20250623095531.GX2824380@black.fi.intel.com> (raw)
In-Reply-To: <20250622171705.4148948-1-alok.a.tiwari@oracle.com>
On Sun, Jun 22, 2025 at 10:17:02AM -0700, Alok Tiwari wrote:
> The tb_dp_port_set_hops() function was incorrectly clearing
> ADP_DP_CS_1_AUX_RX_HOPID_MASK twice.
> According to the function's purpose, it should clear both TX and RX AUX
> hop ID fields.
> Replace the first instance with ADP_DP_CS_1_AUX_TX_HOPID_MASK to ensure
> proper configuration of both AUX directions.
>
> Fixes: 98176380cbe5 ("thunderbolt: Convert DP adapter register names to follow the USB4 spec")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Applied to thunderbolt.git/fixes, thanks!
prev parent reply other threads:[~2025-06-23 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-22 17:17 Alok Tiwari
2025-06-22 17:17 ` [PATCH 2/2] thunderbolt: Fix typos in documentation comments Alok Tiwari
2025-06-23 9:57 ` Mika Westerberg
2025-06-23 9:55 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250623095531.GX2824380@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®