Re: [PATCH net] i40e: Match VF MAC deletion behaviour with OOT driver

[Simon Horman <horms@kernel.org>]

On Mon, Jun 23, 2025 at 09:04:41AM +1000, Jamie Bainbridge wrote:
> When the PF is processing an AQ message to delete a VF's MACs from the
> MAC filter, the Linux kernel driver checks if the PF set the MAC and if
> the VF is trusted. However, the out-of-tree driver has intentionally
> removed the check for VF trust with OOT driver version 2.26.8.
> 
> This results in an undesirable behaviour difference between the OOT
> driver and the Linux driver, where if a trusted VF with a PF-set MAC
> sets itself down (which sends an AQ message to delete the VF's MAC
> filters) then the VF MAC is erased from the interface with the Linux
> kernel driver but not with the OOT driver.
> 
> This results in the VF losing its PF-set MAC which should not happen.
> 
> Change the Linux kernel driver and comment to match the OOT behaviour.
> 
> Fixes: ea2a1cfc3b201 ("i40e: Fix VF MAC filter removal")
> Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>

Hi Jamie,

I hate to be a pain but I'm wondering if we could rephrase the subject
and patch description to emphasis that this is correcting undesirable
(incorrect?) behaviour. And as a footnote, that the new behaviour matches
the OOT driver.

Correctness is what matters most from an upstream PoV.

Thanks!