From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, shenjian15@huawei.com,
wangpeiyang1@huawei.com, liuyonglong@huawei.com,
chenhao418@huawei.com, jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 net-next 5/8] net: hns3: set the freed pointers to NULL when lifetime is not end
Date: Mon, 23 Jun 2025 17:21:13 +0100 [thread overview]
Message-ID: <20250623162113.GC506049@horms.kernel.org> (raw)
In-Reply-To: <fc76feab-8390-43dc-9de6-e1d53bd9986d@huawei.com>
On Mon, Jun 23, 2025 at 09:44:45AM +0800, Jijie Shao wrote:
>
> on 2025/6/21 23:33, Jakub Kicinski wrote:
> > On Thu, 19 Jun 2025 22:40:54 +0800 Jijie Shao wrote:
> > > ChangeLog:
> > > v2 -> v3:
> > > - Remove unnecessary pointer set to NULL operation, suggested by Simon Horman.
> > > v2: https://lore.kernel.org/all/20250617010255.1183069-1-shaojijie@huawei.com/
> > You removed a single case, but I'm pretty sure Simon meant _all_
> > cases setting local variables to NULL in this patch are pointless.
>
> Ok, I will drop this patch in V4
Thanks, much appreciated.
next prev parent reply other threads:[~2025-06-23 16:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 14:40 [PATCH V3 net-next 0/8] There are some cleanup for hns3 driver Jijie Shao
2025-06-19 14:40 ` [PATCH V3 net-next 1/8] net: hns3: fix spelling mistake "reg_um" -> "reg_num" Jijie Shao
2025-06-19 14:40 ` [PATCH V3 net-next 2/8] net: hns3: use hns3_get_ae_dev() helper to reduce the unnecessary middle layer conversion Jijie Shao
2025-06-19 14:40 ` [PATCH V3 net-next 3/8] net: hns3: use hns3_get_ops() " Jijie Shao
2025-06-19 14:40 ` [PATCH V3 net-next 4/8] net: hns3: add \n at the end when print msg Jijie Shao
2025-06-19 14:40 ` [PATCH V3 net-next 5/8] net: hns3: set the freed pointers to NULL when lifetime is not end Jijie Shao
2025-06-21 15:33 ` Jakub Kicinski
2025-06-23 1:44 ` Jijie Shao
2025-06-23 16:21 ` Simon Horman [this message]
2025-06-19 14:40 ` [PATCH V3 net-next 6/8] net: hns3: delete redundant address before the array Jijie Shao
2025-06-19 14:40 ` [PATCH V3 net-next 7/8] net: hns3: add complete parentheses for some macros Jijie Shao
2025-06-19 14:40 ` [PATCH V3 net-next 8/8] net: hns3: clear hns alarm: comparison of integer expressions of different signedness Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250623162113.GC506049@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangpeiyang1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®