mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Khalid Ali <khaliidcaliy@gmail.com>
To: brgerst@gmail.com, tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de, dave.hansen@linux.intel.com, ubizjak@gmail.com
Cc: x86@kernel.org, hpa@zytor.com, linux-efi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/3] x86/boot: Supply boot_param in rdi instead of rsi from startup_64()
Date: Mon, 23 Jun 2025 16:29:34 +0000	[thread overview]
Message-ID: <20250623162935.681-1-khaliidcaliy@gmail.com> (raw)
In-Reply-To: <CAMzpN2jBOW3PVJQLvua=knQNu_1mZ6RZYi8JvNenFd5t30UC1Q@mail.gmail.com>

> This was never intended to conform to the C ABI, why is it necessary
> to change it?

Technically speaking, you are right, however that doesn't mean we can put something where
ever we like. We came from C code which is bootloader and we end up to C code, so we should 
comply the ABI here too.

> Also, you cannot break this up into three patches.  Every patch must
> be fully functional so that git bisect will work.

Thanks for the tip. I will do next time.

  reply	other threads:[~2025-06-23 16:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23  8:14 Khalid Ali
2025-06-23 12:33 ` Brian Gerst
2025-06-23 16:29   ` Khalid Ali [this message]
2025-06-23 18:19     ` H. Peter Anvin
2025-06-23 18:39       ` Khalid Ali
2025-06-23 19:24         ` Brian Gerst
2025-06-24  0:43           ` H. Peter Anvin
2025-06-24  0:49         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250623162935.681-1-khaliidcaliy@gmail.com \
    --to=khaliidcaliy@gmail.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=ubizjak@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®