mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: GalaxySnail <me@glxys.nl>
To: simont@opensource.cirrus.com
Cc: david.rhodes@cirrus.com, linux-kernel@vger.kernel.org,
	linux-sound@vger.kernel.org, lkp@intel.com, me@glxys.nl,
	oe-kbuild-all@lists.linux.dev, patches@opensource.cirrus.com,
	perex@perex.cz, rf@opensource.cirrus.com, tiwai@suse.com
Subject: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
Date: Tue, 24 Jun 2025 18:17:17 +0800	[thread overview]
Message-ID: <20250624101716.2365302-2-me@glxys.nl> (raw)
In-Reply-To: <002901dbe4ef$57d0cce0$077266a0$@opensource.cirrus.com>

add firmware information in the .modinfo section, so that userspace
tools can find out firmware required by cs35l41/cs35l56 kernel module

Signed-off-by: GalaxySnail <me@glxys.nl>
---
Thanks for your review!

v2 -> v3: fixed typo
v1 -> v2: fixed missing ';' in the previous patch

 sound/pci/hda/cs35l41_hda.c | 2 ++
 sound/pci/hda/cs35l56_hda.c | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index d5bc81099d0d..17cdce91fdbf 100644
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
 MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>");
 MODULE_LICENSE("GPL");
 MODULE_IMPORT_NS("FW_CS_DSP");
+MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw");
+MODULE_FIRMWARE("cirrus/cs35l41-*.bin");
diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
index 3f2fd32f4ad9..eedd8fdd3b8b 100644
--- a/sound/pci/hda/cs35l56_hda.c
+++ b/sound/pci/hda/cs35l56_hda.c
@@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
 MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>");
 MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>");
 MODULE_LICENSE("GPL");
+MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw");
+MODULE_FIRMWARE("cirrus/cs35l54-*.bin");
+MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw");
+MODULE_FIRMWARE("cirrus/cs35l56-*.bin");
-- 
2.50.0


  reply	other threads:[~2025-06-24 10:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 14:00 [PATCH] " GalaxySnail
2025-06-24  3:56 ` kernel test robot
2025-06-24  4:31   ` [PATCH v2] " GalaxySnail
2025-06-24 10:04     ` Simon Trimmer
2025-06-24 10:17       ` GalaxySnail [this message]
2025-06-24 10:44         ` [PATCH v3] " Takashi Iwai
2025-06-24 11:25           ` GalaxySnail
2025-07-04 12:02         ` Takashi Iwai
2025-07-04 12:33         ` Richard Fitzgerald
2025-07-06  8:23         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250624101716.2365302-2-me@glxys.nl \
    --to=me@glxys.nl \
    --cc=david.rhodes@cirrus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=simont@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®