From: Maxime Ripard <mripard@kernel.org>
To: Dharma Balasubiramani <dharma.b@microchip.com>
Cc: Manikandan Muralidharan <manikandan.m@microchip.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] drm/bridge: microchip-lvds: migrate to atomic bridge ops
Date: Wed, 25 Jun 2025 08:54:15 +0200 [thread overview]
Message-ID: <20250625-fuzzy-expert-mackerel-6edb0a@houat> (raw)
In-Reply-To: <20250625-microchip-lvds-v5-2-624cf72b2651@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
On Wed, Jun 25, 2025 at 10:26:10AM +0530, Dharma Balasubiramani wrote:
> Replace legacy .enable and .disable callbacks with their atomic
> counterparts .atomic_enable and .atomic_disable.
>
> Also, add turn off the serialiser inside atomic_disable().
>
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
As a rule of thumb, if you have "Also, do X" in your commit log, you
need a separate patch.
And you need to explain why turning off the serialiser inside
atomic_disable() is needed. It might make sense to you, it's not really
obvious to me from that patch, and it will definitely not be to someone
trying to identify fixes and doing backports.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
next prev parent reply other threads:[~2025-06-25 6:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 4:56 [PATCH v5 0/4] drm/bridge: microchip-lvds: clean up and fix bus formats Dharma Balasubiramani
2025-06-25 4:56 ` [PATCH v5 1/4] drm/bridge: microchip-lvds: Remove unused drm_panel and redundant port node lookup Dharma Balasubiramani
2025-06-25 6:52 ` Maxime Ripard
2025-06-25 4:56 ` [PATCH v5 2/4] drm/bridge: microchip-lvds: migrate to atomic bridge ops Dharma Balasubiramani
2025-06-25 6:54 ` Maxime Ripard [this message]
2025-06-25 8:26 ` Dharma.B
2025-06-25 4:56 ` [PATCH v5 3/4] drm/bridge: microchip-lvds: add atomic pre_enable() and post_disable() Dharma Balasubiramani
2025-06-25 6:57 ` Maxime Ripard
2025-06-25 4:56 ` [PATCH v5 4/4] drm/bridge: microchip-lvds: fix bus format mismatch with VESA displays Dharma Balasubiramani
2025-06-25 6:57 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625-fuzzy-expert-mackerel-6edb0a@houat \
--to=mripard@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dharma.b@microchip.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=manikandan.m@microchip.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®