From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: <will@kernel.org>, <mark.rutland@arm.com>,
<linux-cxl@vger.kernel.org>, <linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] perf/cxlpmu: Fix typos in cxl_pmu.c comments and documentation
Date: Wed, 25 Jun 2025 10:05:10 +0100 [thread overview]
Message-ID: <20250625100510.00005f0b@huawei.com> (raw)
In-Reply-To: <20250624194350.109790-4-alok.a.tiwari@oracle.com>
On Tue, 24 Jun 2025 12:43:40 -0700
Alok Tiwari <alok.a.tiwari@oracle.com> wrote:
> Fix several minor typo errors in comments:
> - Remove duplicated word "a" in "a a VID / GroupID".
> - Correct "Opcopdes" to "Opcodes" in CXL spec reference.
> - Fix spelling of "implemnted" to "implemented".
>
> Improves code readability and documentation consistency.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
One day I'll remember to run a spell checker :(
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> ---
> drivers/perf/cxl_pmu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/perf/cxl_pmu.c b/drivers/perf/cxl_pmu.c
> index 5a475a5a1f095..d094030220bf2 100644
> --- a/drivers/perf/cxl_pmu.c
> +++ b/drivers/perf/cxl_pmu.c
> @@ -113,7 +113,7 @@ struct cxl_pmu_info {
>
> /*
> * All CPMU counters are discoverable via the Event Capabilities Registers.
> - * Each Event Capability register contains a a VID / GroupID.
> + * Each Event Capability register contains a VID / GroupID.
> * A counter may then count any combination (by summing) of events in
> * that group which are in the Supported Events Bitmask.
> * However, there are some complexities to the scheme.
> @@ -406,7 +406,7 @@ static struct attribute *cxl_pmu_event_attrs[] = {
> CXL_PMU_EVENT_CXL_ATTR(s2m_bisnp_curblk, CXL_PMU_GID_S2M_BISNP, BIT(4)),
> CXL_PMU_EVENT_CXL_ATTR(s2m_bisnp_datblk, CXL_PMU_GID_S2M_BISNP, BIT(5)),
> CXL_PMU_EVENT_CXL_ATTR(s2m_bisnp_invblk, CXL_PMU_GID_S2M_BISNP, BIT(6)),
> - /* CXL rev 3.1 Table 3-50 S2M NDR Opcopdes */
> + /* CXL rev 3.1 Table 3-50 S2M NDR Opcodes */
> CXL_PMU_EVENT_CXL_ATTR(s2m_ndr_cmp, CXL_PMU_GID_S2M_NDR, BIT(0)),
> CXL_PMU_EVENT_CXL_ATTR(s2m_ndr_cmps, CXL_PMU_GID_S2M_NDR, BIT(1)),
> CXL_PMU_EVENT_CXL_ATTR(s2m_ndr_cmpe, CXL_PMU_GID_S2M_NDR, BIT(2)),
> @@ -627,7 +627,7 @@ static void cxl_pmu_event_start(struct perf_event *event, int flags)
> hwc->state = 0;
>
> /*
> - * Currently only hdm filter control is implemnted, this code will
> + * Currently only hdm filter control is implemented, this code will
> * want generalizing when more filters are added.
> */
> if (info->filter_hdm) {
next prev parent reply other threads:[~2025-06-25 9:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 19:43 [PATCH v2 0/3] perf/cxlpmu: Fix allocation argument order and minor formatting Alok Tiwari
2025-06-24 19:43 ` [PATCH v2 1/3] perf/cxlpmu: Fix devm_kcalloc() argument order in cxl_pmu_probe() Alok Tiwari
2025-06-25 8:59 ` Jonathan Cameron
2025-06-24 19:43 ` [PATCH v2 2/3] perf/cxlpmu: Remove unintended newline from IRQ name format string Alok Tiwari
2025-06-25 9:04 ` Jonathan Cameron
2025-06-24 19:43 ` [PATCH v2 3/3] perf/cxlpmu: Fix typos in cxl_pmu.c comments and documentation Alok Tiwari
2025-06-25 9:05 ` Jonathan Cameron [this message]
2025-07-14 15:10 ` [PATCH v2 0/3] perf/cxlpmu: Fix allocation argument order and minor formatting Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625100510.00005f0b@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alok.a.tiwari@oracle.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®