From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8427A2D8DA9 for ; Wed, 25 Jun 2025 18:58:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750877887; cv=none; b=V/AmU1qNN3EYR+rTAgnttztFAnAR0ch5urg9WGm2b1o74j5OcoJyjwsNYRXgxmcJ/76LvGa6eZVLk/96rI21grwtq5em6uT5VI8onnJq2ogF7vv0l6EsKhj7F8130sT5wvfY+NjfRJDtQnLZapXTSBb3cLCnpS2Ku5ademn5f2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750877887; c=relaxed/simple; bh=zqSdjhSHpkblNmAx7Jv96M9CGYrcB2GAf4tTYELbQ04=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fbemmuhy+qngs+GLQdhbdoF5U5mhGPdHlOqwVj3FnAGgGSZt9QW2nsDCjaqv1Fc/XOQepPUmq4AcvClfk8m0u9hg/XRnMFC+Su1TRpWW7FWSUg1s7Arp7+L5SWhqGceHqFvfRuD+rm9NBpMcKflqtFlcKa/YEH0USOVxJcC/NU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TRba6dtC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TRba6dtC" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55PBcHuQ019632 for ; Wed, 25 Jun 2025 18:58:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=DDaKfWa9JkLEfvmGdiVO0NnfewQC+zJ/d5O OZRnAs2E=; b=TRba6dtCtGbe/MubSW7es+Y2GhsMXIKGvWnKtwsf9YqsenCNEYC iz8DL2F6J+jd/5HvcpBW0q8bs63TrnbJlVIjMzWaJGfEfGaZtKaVYtb8A3cEitFK acGk2xPTW+h+BelSfF5fqXlHrbjOqZafJFtFqa8zOIxHNXalvzgt2o5P0A38Mu5P D2IXTlWUAynFBETUKDHz/DVyQ7bw0nkEcC89X3eU3LVatPPeZKrNlSdMx4zB50+l JKx3kUlJvmSFelDYozEVfkPraWF9PxOHy4N3zzHPFGpkT9UdyNuWsM73LTfmZC45 xw3QsiNKAPJ4HghiA1SVoyMZCahkbyQVmSQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47emcmtjwt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 25 Jun 2025 18:58:04 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-313fab41f4bso171160a91.0 for ; Wed, 25 Jun 2025 11:58:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750877883; x=1751482683; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DDaKfWa9JkLEfvmGdiVO0NnfewQC+zJ/d5OOZRnAs2E=; b=MYsgjrkMcJxh/m11x55SuRq13+j3s/5d1qrmyx6mQYBBPn8Dj6UpFcoVyKoU/+KVD9 tRO6h08m5T7WTyvXHIrRYAZkH735vDovcisRIq+VgLpcxV0JbwvXth6h3YyJA8Jj9F3j vz+/PDUfuep6iMAVgMH2Apg29SPPrMQ7XmMuxjf14seqEGMEbtMlMSaL2ZppUwzlj2za 0j31UdR5N6sxYKFhaBtVd2zEA4zND+UYDT8feZkxDb1shetmdZfAagEBv5dbvosGB+jq +W8lML1RgqDdGn6q06HU56gdIKDK3u4w0GL//VvwHtYYTJalPR9oCGY9jf2kmoVTH219 PToQ== X-Forwarded-Encrypted: i=1; AJvYcCUm5+brphihHkv1JJVNncYGy6Sdva6Kg3KTKx2MEj1LWwpKrobNRFf5uHxha6JxuenBew84c7i0koSrs6M=@vger.kernel.org X-Gm-Message-State: AOJu0YzP68gibmdzpmyT1jgU/V9/gKHkR7wKfFcepHehNbZuojjFmsQp bfpSRBEwM+Mor7xQhcZgY5L2+1pEGU/sQOETZR7y5Eh+Tydv8rO2bsJX7pmfZwhA02YmmtsIuj8 pnUoBPotdwnXfbFE3gbwYEM86V4y4FEAkig+qROswCW0yTRVQz49Ao3V6jb+Xo9PGksk= X-Gm-Gg: ASbGnctCTYVKOuggyuv/zBUpOUrzdEp74Ambl/5wwx/6djMZzDjUTEG/iUmWnUcTEEO T7dFq4WyLr9o+AjZtSokrDez9s8IpAw4twqx0mhE4kwWvcdr7aN22/PDMhPl/81m8yFL7pCpPek CtvcBDoT6XT1pr55pcMg/1h/s9Ywsid691rxa37LWw742tjUUI5jE4v44NcELS8pzmQWoHLPtWX V5mD7/A+UHqzuwgztos+4Hge7S7WOW5tTA7UoW9ADMEYHJVeDPGxL77bFJIoW+Ni9ohkBrmVa4y 1oLX3OX9FWPApVLUDvXECFPnaW65XzQM X-Received: by 2002:a17:90b:2c85:b0:30e:8c5d:8ed with SMTP id 98e67ed59e1d1-315f2671f79mr5632750a91.19.1750877883411; Wed, 25 Jun 2025 11:58:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEK/2z/Vb51VR9atiYC58dhY+k/7pA4s15CdWX0lWPalCEljbEvjEWs9sFQy4l6EbfsNOK8FQ== X-Received: by 2002:a17:90b:2c85:b0:30e:8c5d:8ed with SMTP id 98e67ed59e1d1-315f2671f79mr5632719a91.19.1750877882952; Wed, 25 Jun 2025 11:58:02 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-315f53d94b1sm2380818a91.33.2025.06.25.11.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 11:58:02 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Connor Abbott , Antonino Maniscalco , Rob Clark , Abhinav Kumar , Arnd Bergmann , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Dmitry Baryshkov , Eugene Lepshy , Haoxiang Li , Jessica Zhang , Jun Nie , Konrad Dybcio , Krzysztof Kozlowski , linaro-mm-sig@lists.linaro.org (moderated list:DMA BUFFER SHARING FRAMEWORK:Keyword:\bdma_(?:buf|fence|resv)\b), linux-kernel@vger.kernel.org (open list), linux-media@vger.kernel.org (open list:DMA BUFFER SHARING FRAMEWORK:Keyword:\bdma_(?:buf|fence|resv)\b), Maarten Lankhorst , Marijn Suijten , Maxime Ripard , Rob Clark , Sean Paul , Simona Vetter , Sumit Semwal , Thomas Zimmermann Subject: [PATCH v7 00/42] drm/msm: sparse / "VM_BIND" support Date: Wed, 25 Jun 2025 11:46:53 -0700 Message-ID: <20250625184918.124608-1-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: EGCFvZg1wNdnYDyLKEVo3RN4I8-fRpKK X-Proofpoint-ORIG-GUID: EGCFvZg1wNdnYDyLKEVo3RN4I8-fRpKK X-Authority-Analysis: v=2.4 cv=J+eq7BnS c=1 sm=1 tr=0 ts=685c46bc cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=xqWC_Br6kY4A:10 a=6IFa9wvqVegA:10 a=e5mUnYsNAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=zBYVM8QCAAAA:8 a=PoX65QKItS7eaLYJ0vsA:9 a=eVM1_HBmYRkA:10 a=YgSuLXRpIuYA:10 a=te1wHPZ5H10A:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=Vxmtnl_E_bksehYqCbjh:22 a=ArXkYGXkE6hBHcUMFODu:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI1MDE0MyBTYWx0ZWRfX0najF1kqkSwn wstIMRr2gAUwFZ9mDUCV1SnyKMPhJYriXg7OnQpFqivH/Nm6ZeeDiJGrMReci1w+7bZMwBsoMuh V1U5M7LIXlT8NyVCL7e7OTO/9cC5ItJbPDD1Ongvg1yqOEST+faHfucwPkwZA3brWEMqjUMgksq Y9cAvhtHFp+yE+9MsEXP/dkyiQ4Fmmhxf5r7vdrQsG7bFIApRMiSv7p282E1AwMK6ZILVK1/YJF j/JuY2OvQVhjGHd4J5tXpQauMppVg9wTyvCeoNv/wh/Bsvwh+LcZj4IWF06YRqBMpilUV/8VxBf fiM+OYgEE+QZvHd2vktJeWwc+yb8Jt1NNWE/HTv0jl2Q/CIinLkASqmkmJwdA2JKbyrIIm185pt eZjRedp8LQBG89lX5egRXmySuHc/NxhWpvtivzU8JQokWt8Z4GeIPrt8FL0XTdUfVjR2NSrw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-25_06,2025-06-25_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999 adultscore=0 impostorscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 priorityscore=1501 suspectscore=0 mlxscore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506250143 Conversion to DRM GPU VA Manager[1], and adding support for Vulkan Sparse Memory[2] in the form of: 1. A new VM_BIND submitqueue type for executing VM MSM_SUBMIT_BO_OP_MAP/ MAP_NULL/UNMAP commands 2. A new VM_BIND ioctl to allow submitting batches of one or more MAP/MAP_NULL/UNMAP commands to a VM_BIND submitqueue I did not implement support for synchronous VM_BIND commands. Since userspace could just immediately wait for the `SUBMIT` to complete, I don't think we need this extra complexity in the kernel. Synchronous/immediate VM_BIND operations could be implemented with a 2nd VM_BIND submitqueue. The corresponding mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32533 Changes in v7: - Rebase on, and use, gpuvm locking helpers[4], included in this series. - Various small fixes - Link to v6: https://lore.kernel.org/all/20250605183111.163594-1-robin.clark@oss.qualcomm.com/ Changes in v6: - Drop io-pgtable-arm patch as it has already been picked up in the iommu tree. - Rework to drop gpuvm changes. To mitigate the limitation of gpuvm when it comes to lazy unmap (and to avoid ~5ms of unmap per pageflip!) a vma_ref refcount is added. This refcount is incremented when a BO is pinned for scanout, and for userspace handles and dma-bufs. The VMA is torn down when this count drops to zero, breaking the reference loop between the VM_BO and BO. But as long as a pin or userspace handle is keeping a reference to the BO live, we allow the harmless reference loop to live. (This is only for kernel managed VMs, which includes the kms VM.) If no userspace process has some sort of handle to the BO, it is unlikely to be reused again. (The exception is GET_FB, but in that case the vma_ref >= 1 due to pin for scan- out.) - Drop gpu sched changes for throttling and move this into the driver. We can re-visit a more generic solution when some other driver realizes they need the same thing. - Link to v5: https://lore.kernel.org/all/20250519175348.11924-1-robdclark@gmail.com/ Changes in v5: - Improved drm/sched enqueue_credit comments, and better define the return from drm_sched_entity_push_job() - Improve DRM_GPUVM_VA_WEAK_REF comments, and additional WARN_ON()s to make it clear that some of the gpuvm functionality is not available in this mode. - Link to v4: https://lore.kernel.org/all/20250514175527.42488-1-robdclark@gmail.com/ Changes in v4: - Various locking/etc fixes - Optimize the pgtable preallocation. If userspace sorts the VM_BIND ops then the kernel detects ops that fall into the same 2MB last level PTD to avoid duplicate page preallocation. - Add way to throttle pushing jobs to the scheduler, to cap the amount of potentially temporary prealloc'd pgtable pages. - Add vm_log to devcoredump for debugging. If the vm_log_shift module param is set, keep a log of the last 1< msm_context drm/msm: Improve msm_context comments drm/msm: Rename msm_gem_address_space -> msm_gem_vm drm/msm: Remove vram carveout support drm/msm: Collapse vma allocation and initialization drm/msm: Collapse vma close and delete drm/msm: Don't close VMAs on purge drm/msm: Stop passing vm to msm_framebuffer drm/msm: Refcount framebuffer pins drm/msm: drm_gpuvm conversion drm/msm: Convert vm locking drm/msm: Use drm_gpuvm types more drm/msm: Split out helper to get iommu prot flags drm/msm: Add mmu support for non-zero offset drm/msm: Add PRR support drm/msm: Rename msm_gem_vma_purge() -> _unmap() drm/msm: Drop queued submits on lastclose() drm/msm: Lazily create context VM drm/msm: Add opt-in for VM_BIND drm/msm: Mark VM as unusable on GPU hangs drm/msm: Add _NO_SHARE flag drm/msm: Crashdump prep for sparse mappings drm/msm: rd dumping prep for sparse mappings drm/msm: Crashdump support for sparse drm/msm: rd dumping support for sparse drm/msm: Extract out syncobj helpers drm/msm: Use DMA_RESV_USAGE_BOOKKEEP/KERNEL drm/msm: Add VM_BIND submitqueue drm/msm: Support IO_PGTABLE_QUIRK_NO_WARN_ON drm/msm: Support pgtable preallocation drm/msm: Split out map/unmap ops drm/msm: Add VM_BIND ioctl drm/msm: Add VM logging for VM_BIND updates drm/msm: Add VMA unmap reason drm/msm: Add mmu prealloc tracepoint drm/msm: use trylock for debugfs drm/msm: Bump UAPI version drm/msm: Defer VMA unmap for fb unpins drm/msm: Add VM_BIND throttling drivers/gpu/drm/drm_gem.c | 14 +- drivers/gpu/drm/drm_gpuvm.c | 132 +- drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 25 +- drivers/gpu/drm/msm/adreno/a2xx_gpummu.c | 5 +- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 17 +- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 17 +- drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 22 +- drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 10 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 32 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 49 +- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 6 +- drivers/gpu/drm/msm/adreno/a6xx_preempt.c | 10 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 4 - drivers/gpu/drm/msm/adreno/adreno_gpu.c | 99 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 23 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 11 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 20 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 3 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 +- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 22 +- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2 - drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 6 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 28 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 18 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 19 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 18 +- drivers/gpu/drm/msm/dsi/dsi_host.c | 14 +- drivers/gpu/drm/msm/msm_drv.c | 185 +- drivers/gpu/drm/msm/msm_drv.h | 30 +- drivers/gpu/drm/msm/msm_fb.c | 33 +- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- drivers/gpu/drm/msm/msm_gem.c | 537 +++--- drivers/gpu/drm/msm/msm_gem.h | 276 ++- drivers/gpu/drm/msm/msm_gem_prime.c | 66 + drivers/gpu/drm/msm/msm_gem_shrinker.c | 104 +- drivers/gpu/drm/msm/msm_gem_submit.c | 300 ++-- drivers/gpu/drm/msm/msm_gem_vma.c | 1508 ++++++++++++++++- drivers/gpu/drm/msm/msm_gpu.c | 211 ++- drivers/gpu/drm/msm/msm_gpu.h | 147 +- drivers/gpu/drm/msm/msm_gpu_trace.h | 14 + drivers/gpu/drm/msm/msm_iommu.c | 302 +++- drivers/gpu/drm/msm/msm_kms.c | 18 +- drivers/gpu/drm/msm/msm_kms.h | 2 +- drivers/gpu/drm/msm/msm_mmu.h | 38 +- drivers/gpu/drm/msm/msm_rd.c | 62 +- drivers/gpu/drm/msm/msm_ringbuffer.c | 10 +- drivers/gpu/drm/msm/msm_submitqueue.c | 96 +- drivers/gpu/drm/msm/msm_syncobj.c | 172 ++ drivers/gpu/drm/msm/msm_syncobj.h | 37 + include/drm/drm_gem.h | 10 +- include/drm/drm_gpuvm.h | 8 + include/uapi/drm/msm_drm.h | 149 +- 58 files changed, 3712 insertions(+), 1263 deletions(-) create mode 100644 drivers/gpu/drm/msm/msm_syncobj.c create mode 100644 drivers/gpu/drm/msm/msm_syncobj.h -- 2.49.0