mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+8425ccfb599521edb153@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [rdma?] WARNING in rxe_skb_tx_dtor
Date: Fri, 27 Jun 2025 06:52:09 +0800	[thread overview]
Message-ID: <20250626225210.1924-1-hdanton@sina.com> (raw)
In-Reply-To: <685db3be.a00a0220.2e5631.0362.GAE@google.com>

> Date: Thu, 26 Jun 2025 13:55:26 -0700
> syzbot has found a reproducer for the following issue on:
> 
> HEAD commit:    ee88bddf7f2f Merge tag 'bpf-fixes' of git://git.kernel.org..
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=14367182580000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=79da270cec5ffd65
> dashboard link: https://syzkaller.appspot.com/bug?extid=8425ccfb599521edb153
> compiler:       Debian clang version 20.1.6 (++20250514063057+1e4d39e07757-1~exp1~20250514183223.118), Debian LLD 20.1.6
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=10e9008c580000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=10c12f0c580000

#syz test

--- x/drivers/infiniband/sw/rxe/rxe_net.c
+++ y/drivers/infiniband/sw/rxe/rxe_net.c
@@ -471,6 +471,7 @@ struct sk_buff *rxe_init_packet(struct r
 	struct net_device *ndev;
 	const struct ib_gid_attr *attr;
 	const int port_num = 1;
+	struct rxe_dev *rdev;
 
 	attr = rdma_get_gid_attr(&rxe->ib_dev, port_num, av->grh.sgid_index);
 	if (IS_ERR(attr))
@@ -503,6 +504,17 @@ struct sk_buff *rxe_init_packet(struct r
 	skb->dev	= ndev;
 	rcu_read_unlock();
 
+	rdev = rxe_get_dev_from_net(ndev);
+	if (!rdev && is_vlan_dev(ndev))
+		rdev = rxe_get_dev_from_net(vlan_dev_real_dev(ndev));
+	if (rdev)
+		ib_device_put(&rdev->ib_dev);
+	if (rdev != rxe) {
+		kfree_skb(skb);
+		skb = NULL;
+		goto out;
+	}
+
 	if (av->network_type == RXE_NETWORK_TYPE_IPV4)
 		skb->protocol = htons(ETH_P_IP);
 	else
--

  parent reply	other threads:[~2025-06-26 22:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-01 16:45 syzbot
2025-05-02  9:54 ` Zhu Yanjun
2025-05-13 14:57   ` Zhu Yanjun
2025-06-26 20:55 ` syzbot
2025-06-26 22:22   ` Yanjun.Zhu
2025-06-26 22:25     ` syzbot
2025-06-26 22:38       ` Yanjun.Zhu
2025-06-26 22:54         ` syzbot
2025-06-27  2:49         ` Zhu Yanjun
2025-06-27  3:11           ` syzbot
2025-06-27  3:41             ` Zhu Yanjun
2025-06-27  3:57               ` syzbot
2025-06-27  4:53                 ` Zhu Yanjun
2025-06-27  5:09                   ` syzbot
2025-06-26 22:52   ` Hillf Danton [this message]
2025-06-26 23:09     ` syzbot
2025-06-27 18:27 ` [syzbot] " syzbot
     [not found] <f63acb1b-083f-4a48-8352-d07d48827330@linux.dev>
2025-06-27 18:43 ` syzbot
2025-06-27 19:35   ` Yanjun.Zhu
2025-06-27 19:50     ` syzbot
2025-06-27 20:26       ` Yanjun.Zhu
2025-06-27 20:46         ` syzbot
2025-06-27 23:10           ` Yanjun.Zhu
2025-06-27 23:32             ` syzbot
2025-06-27 23:42               ` Yanjun.Zhu
2025-07-03  0:36                 ` Yanjun.Zhu
2025-07-03  0:58                   ` syzbot
2025-07-06 21:04                     ` Zhu Yanjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250626225210.1924-1-hdanton@sina.com \
    --to=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+8425ccfb599521edb153@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®