mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manish Kumar <manish1588@gmail.com>
To: dan.carpenter@linaro.org
Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	manish1588@gmail.com, sudipm.mukherjee@gmail.com,
	teddy.wang@siliconmotion.com
Subject: Re: [PATCH] staging: sm750fb: make g_fbmode[] a read-only pointer array
Date: Fri, 27 Jun 2025 23:45:58 +0530	[thread overview]
Message-ID: <20250627181600.9814-1-manish1588@gmail.com> (raw)
In-Reply-To: <c8f5f917-8412-408d-9dd9-6635af8825a7@suswa.mountain>

Hi Dan,

Thank you for the review. You're absolutely right — changing the array to `const` breaks the assignments that follow.

I've reverted this and will send a new cleanup patch later.

Regards,  
Manish


  reply	other threads:[~2025-06-27 18:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 17:31 Manish Kumar
2025-06-27 17:35 ` Dan Carpenter
2025-06-27 18:15   ` Manish Kumar [this message]
     [not found]   ` <CAAoxDjcYwV9JhRLGJ+opJLEU5j4RHYUt4XZ8E4R9DgF2VqZD8Q@mail.gmail.com>
2025-06-27 18:18     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250627181600.9814-1-manish1588@gmail.com \
    --to=manish1588@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®