From: Mina Almasry <almasrymina@google.com>
To: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "Mina Almasry" <almasrymina@google.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Shuah Khan" <shuah@kernel.org>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"kernel test robot" <lkp@intel.com>
Subject: [PATCH net-next v1 2/2] selftests: pp-bench: remove page_pool_put_page wrapper
Date: Fri, 27 Jun 2025 20:04:52 +0000 [thread overview]
Message-ID: <20250627200501.1712389-2-almasrymina@google.com> (raw)
In-Reply-To: <20250627200501.1712389-1-almasrymina@google.com>
Minor cleanup: remove the pointless looking _ wrapper around
page_pool_put_page, and just do the call directly.
Signed-off-by: Mina Almasry <almasrymina@google.com>
---
.../net/bench/page_pool/bench_page_pool_simple.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c b/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c
index 1cd3157fb6a9..cb6468adbda4 100644
--- a/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c
+++ b/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c
@@ -16,12 +16,6 @@
static int verbose = 1;
#define MY_POOL_SIZE 1024
-static void _page_pool_put_page(struct page_pool *pool, struct page *page,
- bool allow_direct)
-{
- page_pool_put_page(pool, page, -1, allow_direct);
-}
-
/* Makes tests selectable. Useful for perf-record to analyze a single test.
* Hint: Bash shells support writing binary number like: $((2#101010)
*
@@ -121,7 +115,7 @@ static void pp_fill_ptr_ring(struct page_pool *pp, int elems)
for (i = 0; i < elems; i++)
array[i] = page_pool_alloc_pages(pp, gfp_mask);
for (i = 0; i < elems; i++)
- _page_pool_put_page(pp, array[i], false);
+ page_pool_put_page(pp, array[i], -1, false);
kfree(array);
}
@@ -180,14 +174,14 @@ static int time_bench_page_pool(struct time_bench_record *rec, void *data,
} else if (type == type_ptr_ring) {
/* Normal return path */
- _page_pool_put_page(pp, page, false);
+ page_pool_put_page(pp, page, -1, false);
} else if (type == type_page_allocator) {
/* Test if not pages are recycled, but instead
* returned back into systems page allocator
*/
get_page(page); /* cause no-recycling */
- _page_pool_put_page(pp, page, false);
+ page_pool_put_page(pp, page, -1, false);
put_page(page);
} else {
BUILD_BUG();
--
2.50.0.727.gbf7dc18ff4-goog
next prev parent reply other threads:[~2025-06-27 20:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 20:04 [PATCH net-next v1 1/2] selftests: pp-bench: remove unneeded linux/version.h Mina Almasry
2025-06-27 20:04 ` Mina Almasry [this message]
2025-06-30 10:02 ` [PATCH net-next v1 2/2] selftests: pp-bench: remove page_pool_put_page wrapper Simon Horman
2025-06-30 12:33 ` Toke Høiland-Jørgensen
2025-06-30 15:00 ` Ilias Apalodimas
2025-07-01 15:49 ` Jesper Dangaard Brouer
2025-06-30 10:00 ` [PATCH net-next v1 1/2] selftests: pp-bench: remove unneeded linux/version.h Simon Horman
2025-06-30 12:33 ` Toke Høiland-Jørgensen
2025-06-30 14:19 ` Ilias Apalodimas
2025-07-01 8:56 ` Jesper Dangaard Brouer
2025-07-02 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250627200501.1712389-2-almasrymina@google.com \
--to=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®