From: Fushuai Wang <wangfushuai@baidu.com>
To: <ecree.xilinx@gmail.com>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-net-drivers@amd.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<wangfushuai@baidu.com>
Subject: Re: [PATCH net-next] sfc: siena: eliminate xdp_rxq_info_valid using XDP base API
Date: Sat, 28 Jun 2025 12:19:29 +0800 [thread overview]
Message-ID: <20250628041929.47704-1-wangfushuai@baidu.com> (raw)
In-Reply-To: <3a9be6e3-7533-4216-aecc-7261b4adf8af@gmail.com>
>> Commit eb9a36be7f3e ("sfc: perform XDP processing on received packets")
>> and commit d48523cb88e0 ("sfc: Copy shared files needed for Siena
>> (part 2)") use xdp_rxq_info_valid to track failures of xdp_rxq_info_reg().
>> However, this driver-maintained state becomes redundant since the XDP
>> framework already provides xdp_rxq_info_is_reg() for checking registration
>> status.
>>
>> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
>
> Looks alright except that subject prefix is misleading as it sounds like
> it's just patching siena rather than both siena and ef10.
> I'd suggest splitting this into two patches, one just touching the siena
> version with this title, the other with subject prefix just "sfc: ".
Hi, Edward
I'll split this into two separate patches and send the update
patches shortly.
--
Regards,
Wang
prev parent reply other threads:[~2025-06-28 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 15:59 Fushuai Wang
2025-06-27 15:34 ` Edward Cree
2025-06-28 4:19 ` Fushuai Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250628041929.47704-1-wangfushuai@baidu.com \
--to=wangfushuai@baidu.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®