Re: [PATCH] drivers: staging: iio: frequency: ad9832.h: Fixed TODO note.

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 27 Jun 2025 15:32:43 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 6/27/25 2:29 PM, Abdalla Ahmad wrote:
> > Hi  
> 
> ...
> 
> >   
> >> Ideally this should be dropped from any global header file. If one needs
> >> something like this, it can be propagated via software nodes.> Well, Including it in include/linux/iio/ made sense to me, would you please elaborate?  
> >   
> 
> No one uses platform data anymore. We use linux/properties.h instead to give
> named properties for this sort of thing. So the right thing to do would be to
> create a proper devicetree binding for the chip to define the properties and
> fix up the driver so that we can move it out of staging. Then the header file
> would just be deleted as part of these changes when we stop using platform
> data.
> 
> If you don't care about the driver and just want the TODO to go away, then
> we can just delete the comment since it is no longer applicable. It doesn't
> make sense to move the header out of staging without moving the rest of the
> driver out of staging at the same time.
> 

I think larger, better change would be to also delete the platform data definition
and the use of it in the driver.  I don't think the content needs to come
from firmware or board files.

Jonathan