From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: accel: mma9553: make mma9553_event_info const
Date: Sun, 29 Jun 2025 17:45:49 +0100 [thread overview]
Message-ID: <20250629174549.1dc6ab33@jic23-huawei> (raw)
In-Reply-To: <20250628-iio-const-data-2-v1-1-a61da3a0941e@baylibre.com>
On Sat, 28 Jun 2025 11:00:07 -0500
David Lechner <dlechner@baylibre.com> wrote:
> Add const qualifier to struct mma9553_event_info mma9553_event_info[].
> This is read-only data so it can be made const.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Seems fine to me. Applied to the togreg branch of iio.git
and pushed out as testing.
This one was a little fiddly to check though so more eyes
would still be good!
Jonathan
> ---
> drivers/iio/accel/mma9553.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
> index ffb0d6ff37124e5f364168c5c4f348a02d28842a..f85384a7908f253f9ed55dae4e0a41a39ae6016b 100644
> --- a/drivers/iio/accel/mma9553.c
> +++ b/drivers/iio/accel/mma9553.c
> @@ -97,7 +97,7 @@ enum activity_level {
> ACTIVITY_RUNNING,
> };
>
> -static struct mma9553_event_info {
> +static const struct mma9553_event_info {
> enum iio_chan_type type;
> enum iio_modifier mod;
> enum iio_event_direction dir;
> @@ -152,7 +152,7 @@ static struct mma9553_event_info {
> #define MMA9553_EVENTS_INFO_SIZE ARRAY_SIZE(mma9553_events_info)
>
> struct mma9553_event {
> - struct mma9553_event_info *info;
> + const struct mma9553_event_info *info;
> bool enabled;
> };
>
>
> ---
> base-commit: 14071b9cf2d751ff9bc8b5e43fa94fbf08aceea1
> change-id: 20250628-iio-const-data-2-7d2afbbe7f88
>
> Best regards,
prev parent reply other threads:[~2025-06-29 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 16:00 David Lechner
2025-06-29 16:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250629174549.1dc6ab33@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®