From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A08D9231856 for ; Sun, 29 Jun 2025 17:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=163.172.96.212 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751219810; cv=none; b=ibgna5/FEU5UAcAbym4KR01PEPnD6pD9TeXOb6aQofGO3LAl0rKsnUp2exAmyYFWpYjrAIuULLz3BRrb20bTff5XhWq1bWusDvdwBfx6pU5QtZ2avAWGo7vNlzJPOmYa7OczbvMfBRyoCbZiE/5WpcfTDVfutREzqPwSc633lig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751219810; c=relaxed/simple; bh=tXM8AJhl8bpSvAiAZTCg9Ecbjt17dQ93+7ODnd8JEUU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZeEEppXOJcUfiLkt1xYWM/rswF0pPL0H0S06fg9PSM/9fug2Kg4tkpbxzOvw0YgLKvWsCjOHp1i+nebiceXRBONjkOH3O2GEyWD/+Gpx1Nv65OY7plXf7NhiROUvxPB2HhlYu8Jh8DsH03a3X64TL1N4KAzgW4IDtnsX4g+98Oc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; arc=none smtp.client-ip=163.172.96.212 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 55THuetg021737; Sun, 29 Jun 2025 19:56:40 +0200 Date: Sun, 29 Jun 2025 19:56:40 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] tools/nolibc: move FD_* definitions to sys/select.h Message-ID: <20250629175640.GA21675@1wt.eu> References: <20250629092552.GA30947@1wt.eu> <029f24fa-3512-4736-94a0-e158c158cc8e@t-8ch.de> <20250629094048.GA26861@1wt.eu> <20250629151006.GA16826@1wt.eu> <20250629160823.GA2302@1wt.eu> <2322d3a1-a5ff-40ec-ad7e-1580f85d95f4@t-8ch.de> <20250629161908.GB2302@1wt.eu> <38b487e0-4d72-4a87-8fc4-c13b4fb35feb@t-8ch.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <38b487e0-4d72-4a87-8fc4-c13b4fb35feb@t-8ch.de> User-Agent: Mutt/1.10.1 (2018-07-13) On Sun, Jun 29, 2025 at 06:27:27PM +0200, Thomas Weißschuh wrote: > On 2025-06-29 18:19:08+0200, Willy Tarreau wrote: > > On Sun, Jun 29, 2025 at 06:14:01PM +0200, Thomas Weißschuh wrote: > > > On 2025-06-29 18:08:23+0200, Willy Tarreau wrote: > > > > On Sun, Jun 29, 2025 at 05:54:02PM +0200, Thomas Weißschuh wrote: > > > > > I saw the same issue, but only because of the changes to types.h. > > > > > And these should not be necessary in the first place. > > > > > > > > You mean fd_set definition ? It's solely a matter of includes ordering > > > > in fact, since it depends on FD_SETSIZE. > > > > > > No, I mean the '#include "sys/select.h"' in "types.h". > > > > I had already dropped it as well. > > Hm, then I'm not sure where it commes from. I noticed that you included linux/unistd.h from sys/select.h, which I didn't have, maybe it plays a role as well. > > > That breaks the dependency order, as it pulls in all kinds of other > > > stuff into the beginning of "types.h" which themselves depend on > > > definitions of "types.h". > > > > It was not just this. I'm pretty sure that what unbroke it for you is > > keeping fd_set in types.h. > > But I *did* move fd_set to sys/select.h. Sorry then, I just didn't notice it while trying to comapre the differences. > > > > > The below works nicely for me: > > > > > > > > OK. Do you prefer that we take that one or just a stub ? I'm personally > > > > fine with both. > > > > > > I prefer moving the code. > > > > OK. Do you want me to merge your patch or will you take care of it ? > > As you'll resubmit your series anyways, please pick up my proposal. OK will do that. Thanks. willy