mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Clark <robin.clark@oss.qualcomm.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	Connor Abbott <cwabbott0@gmail.com>,
	Antonino Maniscalco <antomani103@gmail.com>,
	Danilo Krummrich <dakr@redhat.com>,
	Rob Clark <robdclark@chromium.org>,
	Rob Clark <robin.clark@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v9 30/42] drm/msm: Use DMA_RESV_USAGE_BOOKKEEP/KERNEL
Date: Sun, 29 Jun 2025 13:13:13 -0700	[thread overview]
Message-ID: <20250629201530.25775-31-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20250629201530.25775-1-robin.clark@oss.qualcomm.com>

From: Rob Clark <robdclark@chromium.org>

Any place we wait for a BO to become idle, we should use BOOKKEEP usage,
to ensure that it waits for _any_ activity.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
Tested-by: Antonino Maniscalco <antomani103@gmail.com>
Reviewed-by: Antonino Maniscalco <antomani103@gmail.com>
---
 drivers/gpu/drm/msm/msm_gem.c          | 6 +++---
 drivers/gpu/drm/msm/msm_gem_shrinker.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index 100d159d52e2..b688d397cc47 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -93,8 +93,8 @@ static void msm_gem_close(struct drm_gem_object *obj, struct drm_file *file)
 	 * TODO we might need to kick this to a queue to avoid blocking
 	 * in CLOSE ioctl
 	 */
-	dma_resv_wait_timeout(obj->resv, DMA_RESV_USAGE_READ, false,
-			      msecs_to_jiffies(1000));
+	dma_resv_wait_timeout(obj->resv, DMA_RESV_USAGE_BOOKKEEP, false,
+			      MAX_SCHEDULE_TIMEOUT);
 
 	msm_gem_lock_vm_and_obj(&exec, obj, ctx->vm);
 	put_iova_spaces(obj, ctx->vm, true);
@@ -895,7 +895,7 @@ bool msm_gem_active(struct drm_gem_object *obj)
 	if (to_msm_bo(obj)->pin_count)
 		return true;
 
-	return !dma_resv_test_signaled(obj->resv, dma_resv_usage_rw(true));
+	return !dma_resv_test_signaled(obj->resv, DMA_RESV_USAGE_BOOKKEEP);
 }
 
 int msm_gem_cpu_prep(struct drm_gem_object *obj, uint32_t op, ktime_t *timeout)
diff --git a/drivers/gpu/drm/msm/msm_gem_shrinker.c b/drivers/gpu/drm/msm/msm_gem_shrinker.c
index 5faf6227584a..1039e3c0a47b 100644
--- a/drivers/gpu/drm/msm/msm_gem_shrinker.c
+++ b/drivers/gpu/drm/msm/msm_gem_shrinker.c
@@ -139,7 +139,7 @@ evict(struct drm_gem_object *obj, struct ww_acquire_ctx *ticket)
 static bool
 wait_for_idle(struct drm_gem_object *obj)
 {
-	enum dma_resv_usage usage = dma_resv_usage_rw(true);
+	enum dma_resv_usage usage = DMA_RESV_USAGE_BOOKKEEP;
 	return dma_resv_wait_timeout(obj->resv, usage, false, 10) > 0;
 }
 
-- 
2.50.0


  parent reply	other threads:[~2025-06-29 20:17 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-29 20:12 [PATCH v9 00/42] drm/msm: sparse / "VM_BIND" support Rob Clark
2025-06-29 20:12 ` [PATCH v9 01/42] drm/gpuvm: Fix doc comments Rob Clark
2025-06-29 20:12 ` [PATCH v9 02/42] drm/gpuvm: Add locking helpers Rob Clark
2025-06-29 20:12 ` [PATCH v9 03/42] drm/gem: Add ww_acquire_ctx support to drm_gem_lru_scan() Rob Clark
2025-06-29 20:12 ` [PATCH v9 04/42] drm/msm: Rename msm_file_private -> msm_context Rob Clark
2025-06-29 20:12 ` [PATCH v9 05/42] drm/msm: Improve msm_context comments Rob Clark
2025-06-29 20:12 ` [PATCH v9 06/42] drm/msm: Rename msm_gem_address_space -> msm_gem_vm Rob Clark
2025-06-29 20:12 ` [PATCH v9 07/42] drm/msm: Remove vram carveout support Rob Clark
2025-06-29 20:12 ` [PATCH v9 08/42] drm/msm: Collapse vma allocation and initialization Rob Clark
2025-06-29 20:12 ` [PATCH v9 09/42] drm/msm: Collapse vma close and delete Rob Clark
2025-06-29 20:12 ` [PATCH v9 10/42] drm/msm: Don't close VMAs on purge Rob Clark
2025-06-29 20:12 ` [PATCH v9 11/42] drm/msm: Stop passing vm to msm_framebuffer Rob Clark
2025-06-29 20:12 ` [PATCH v9 12/42] drm/msm: Refcount framebuffer pins Rob Clark
2025-06-29 20:12 ` [PATCH v9 13/42] drm/msm: drm_gpuvm conversion Rob Clark
2025-06-29 20:12 ` [PATCH v9 14/42] drm/msm: Convert vm locking Rob Clark
2025-08-12  8:58   ` Danilo Krummrich
2025-08-13  1:52     ` Rob Clark
2025-06-29 20:12 ` [PATCH v9 15/42] drm/msm: Use drm_gpuvm types more Rob Clark
2025-06-29 20:12 ` [PATCH v9 16/42] drm/msm: Split out helper to get iommu prot flags Rob Clark
2025-06-29 20:13 ` [PATCH v9 17/42] drm/msm: Add mmu support for non-zero offset Rob Clark
2025-06-29 20:13 ` [PATCH v9 18/42] drm/msm: Add PRR support Rob Clark
2025-06-29 20:13 ` [PATCH v9 19/42] drm/msm: Rename msm_gem_vma_purge() -> _unmap() Rob Clark
2025-06-29 20:13 ` [PATCH v9 20/42] drm/msm: Drop queued submits on lastclose() Rob Clark
2025-06-29 20:13 ` [PATCH v9 21/42] drm/msm: Lazily create context VM Rob Clark
2025-06-29 20:13 ` [PATCH v9 22/42] drm/msm: Add opt-in for VM_BIND Rob Clark
2025-06-29 20:13 ` [PATCH v9 23/42] drm/msm: Mark VM as unusable on GPU hangs Rob Clark
2025-06-29 20:13 ` [PATCH v9 24/42] drm/msm: Add _NO_SHARE flag Rob Clark
2025-06-29 20:13 ` [PATCH v9 25/42] drm/msm: Crashdump prep for sparse mappings Rob Clark
2025-06-29 20:13 ` [PATCH v9 26/42] drm/msm: rd dumping " Rob Clark
2025-06-29 20:13 ` [PATCH v9 27/42] drm/msm: Crashdump support for sparse Rob Clark
2025-06-29 20:13 ` [PATCH v9 28/42] drm/msm: rd dumping " Rob Clark
2025-06-29 20:13 ` [PATCH v9 29/42] drm/msm: Extract out syncobj helpers Rob Clark
2025-06-29 20:13 ` Rob Clark [this message]
2025-06-29 20:13 ` [PATCH v9 31/42] drm/msm: Add VM_BIND submitqueue Rob Clark
2025-06-29 20:13 ` [PATCH v9 32/42] drm/msm: Support IO_PGTABLE_QUIRK_NO_WARN_ON Rob Clark
2025-06-29 20:13 ` [PATCH v9 33/42] drm/msm: Support pgtable preallocation Rob Clark
2025-06-29 20:13 ` [PATCH v9 34/42] drm/msm: Split out map/unmap ops Rob Clark
2025-06-29 20:13 ` [PATCH v9 35/42] drm/msm: Add VM_BIND ioctl Rob Clark
2025-06-29 20:13 ` [PATCH v9 36/42] drm/msm: Add VM logging for VM_BIND updates Rob Clark
2025-06-29 20:13 ` [PATCH v9 37/42] drm/msm: Add VMA unmap reason Rob Clark
2025-06-29 20:13 ` [PATCH v9 38/42] drm/msm: Add mmu prealloc tracepoint Rob Clark
2025-06-29 20:13 ` [PATCH v9 39/42] drm/msm: use trylock for debugfs Rob Clark
2025-06-29 20:13 ` [PATCH v9 40/42] drm/msm: Bump UAPI version Rob Clark
2025-06-29 20:13 ` [PATCH v9 41/42] drm/msm: Defer VMA unmap for fb unpins Rob Clark
2025-06-29 20:13 ` [PATCH v9 42/42] drm/msm: Add VM_BIND throttling Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250629201530.25775-31-robin.clark@oss.qualcomm.com \
    --to=robin.clark@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=antomani103@gmail.com \
    --cc=cwabbott0@gmail.com \
    --cc=dakr@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jessica.zhang@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robdclark@chromium.org \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®