From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC48B239E95 for ; Mon, 30 Jun 2025 08:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270578; cv=none; b=oJWWKSt7nDSaIGPpgYRtctmRSBlOJ+/lzcbmUE/5qX8a7ClGnhXJ4IqusicbXv7mFKy/REvMHYOqCPkB1WWR7lWkkjtQh+WAQkNU7R8fxBoqBOyb5aCpwE0iuLGb02uBYmFwV52VmbtBTZDXdTlz3sUIJ6jC8vLkPi2gEoGB8AU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270578; c=relaxed/simple; bh=zgMSdYUK9yNCJ2s3hpP0j/gTKnVm2enHM9w454p24n8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fk3vATxGGpCWCIgnjHAJMSoq2xu9y5iw5xgLvu+h8O6x49XiPXr06fBM9F72sGyOIHmHwwIOgi/kMwJCmqtzhqKNJOe8CjX9ewxsor+pI+bVJ5VlPwPAHHoNq0Oe7pGH9Au3oFmbpDo5WLljaw3oTpJgbJ9aLqX7pEOst0mmgJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=ZwMmpHJ2; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="ZwMmpHJ2" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3a6cd1a6fecso4382373f8f.3 for ; Mon, 30 Jun 2025 01:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1751270575; x=1751875375; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ska9I3Y1aB1MGchq/+g1Gg5HtDvHRWWCZw8erAwmjVs=; b=ZwMmpHJ2okjzzQ4B6SP6Qq14E3pyLz0aagaOtFlMmzclPHu6kCxYhMsA8IlPb6rHrn tB6PeFJ12MwiAzQJVMyk0CGMvkqBeLh1oZ0L8rC3E3GkdgAju3prK3MTfnXAzVOcV/U4 YQ/phOWMNw2mQ53n2bix8LE7HZtIl+hAm0pThaMsdzlefeCa3u9qAgjytWRHks4xnLR2 t6GvXnIAPwOLvQ2Toh6ScIuLLmlWEtKCGtOId8hpAggSpkrvKW/4VN6qr2aqPG4/BTK0 hCj3Uv4lBm1YlTu68O/WopzvY29xiQbN2g1zkkfT0aMefKyfx5hLpIDkvYurRhD3FE0f Xr9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751270575; x=1751875375; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ska9I3Y1aB1MGchq/+g1Gg5HtDvHRWWCZw8erAwmjVs=; b=EO62ZyiJc9Dg48iBonGBArrIs1r4oumPqWOiIxc++maLV29I4rTaqbuuQA1Q/BdM1C moDWH0BVQKondmT8oZzH6KlHHCI6UQgw5h9HxsW2Bn8rpAw5kXGEdbt7bYqvFVxGRcJ+ dt4Yw5HH6Fa8xTp4yOqOu8UDjttZ9466zmvkzFbdQs2dkgl8hwkq7M7i6yC0TBUQmSXU zajnEMvGXdUD103K0/bOVNT/IK6tA2L3x6Vwkka1XFFVRrZAVUXTH5v7yomMpiJWuf2G sSxXPi7H3L56cLV7epEcQyBHN9OHTPNO4B9+3+qccR89ZP5HCkRwHkiBjsBaEAzqJ3KN mw7Q== X-Gm-Message-State: AOJu0YxSLXwaYCz6IBdoTYL3kO1F+TZnfuQDgS+sHreYMuhcF6bgQiQQ tljYNmHH/pyWGGOTvTy2mRTsfr6r0+4V1FLW5MxhugJjY3r8VkjEsaEQxIrcOUG/h9o= X-Gm-Gg: ASbGnctvyOLS/Dvic5PAHtf7E7RsvGeKH+p3mk3RmUgdjEOATwo84ABeJTjCdoUBQQu WQOOou4o5S5B72OGmYIUjbFoEqVNcwJeFNajBbXua3vDF1qfM4bhjfni6vUq6pl5th//x5EdJXW 3fna2W1THn1nVOIot6u65SUTW/LDQGbIF9bIVoqAGd0jck5sjUVuMHtw8q0hG+PqanHP9XIz7+u sGInYP30WDm0E8NpZSvtFFKwKt1YrFvkYTQdc3fYzHjJ5TuGrdeE2zusOu3Rtti5kUJMlwU8aI9 OHAgQkuND5eFfb7E0MU3kiebh3fdE7CYMsBGSB/RrIs9fqWWGSuZ/iIS/gI1 X-Google-Smtp-Source: AGHT+IF9DvJJg0skDidkDsih4Ch3HhJLBIarQJZKBHX8xHPqB+4mHwpjYWK0XFUsByASmkbm+oOmbg== X-Received: by 2002:a05:6000:dcb:b0:3a5:8977:e10f with SMTP id ffacd0b85a97d-3a917603b5cmr7981361f8f.28.1751270574863; Mon, 30 Jun 2025 01:02:54 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200::5485]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e5f842sm9499471f8f.86.2025.06.30.01.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 01:02:54 -0700 (PDT) Date: Mon, 30 Jun 2025 10:02:53 +0200 From: Andrew Jones To: Sunil V L Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "Rafael J . Wysocki" , Len Brown , Tomasz Jeznach , Joerg Roedel , Will Deacon , Robin Murphy , Anup Patel , Atish Patra , "Rafael J . Wysocki" Subject: Re: [PATCH v3 2/3] ACPI: scan: Add support for RISC-V in acpi_iommu_configure_id() Message-ID: <20250630-c479c6607cf8c1430f11336f@orel> References: <20250630034803.1611262-1-sunilvl@ventanamicro.com> <20250630034803.1611262-3-sunilvl@ventanamicro.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250630034803.1611262-3-sunilvl@ventanamicro.com> On Mon, Jun 30, 2025 at 09:18:02AM +0530, Sunil V L wrote: > acpi_iommu_configure_id() currently supports only IORT (ARM) and VIOT. > Add support for RISC-V as well. > > Signed-off-by: Sunil V L > Acked-by: Rafael J. Wysocki > --- > drivers/acpi/scan.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index fb1fe9f3b1a3..70f57d58fd61 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1628,8 +1629,12 @@ static int acpi_iommu_configure_id(struct device *dev, const u32 *id_in) > } > > err = iort_iommu_configure_id(dev, id_in); > - if (err && err != -EPROBE_DEFER) > - err = viot_iommu_configure(dev); > + if (err && err != -EPROBE_DEFER) { > + err = rimt_iommu_configure_id(dev, id_in); > + if (err && err != -EPROBE_DEFER) > + err = viot_iommu_configure(dev); > + } This can just be err = iort_iommu_configure_id(dev, id_in); if (err... err = rimt_iommu_configure_id(dev, id_in); if (err... err = viot_iommu_configure(dev); Thanks, drew > + > mutex_unlock(&iommu_probe_device_lock); > > return err; > -- > 2.43.0 >