From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64B8A849C; Mon, 30 Jun 2025 07:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270063; cv=none; b=cZ0NIToNFFWIVpbz4vSCZ1EaLjagegwLvqTqyRf4GeiNAX73/LO2Y3eqDzsfpLMYODimYQ/n0dBtqdjafDVVneq8dXE8uN+GIyeucI2AbET/yMu2qxwQCp78ZUjbkLJajpkRrr01v8jsiYxp47WvJfYuO0fUKyOul1HoJ5AL/Pw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751270063; c=relaxed/simple; bh=PXl0ept1ioy+QNjeSyQT0UI/4ZmVoSjFJun6pODJeUk=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j4qQFgx/uyTlOOUl14Wm7SbSnOFvjS3vM//SA0Y4v5JVm4tFKvvDckl0BnlKQ4MXpr/JXSApyRSZS5ayjgnX0R6dg2kdzRf1pInU4/MTrGWTcgP8aN+YYXHQ6rH/jhvnsTm68rAUORAqu0uciYWFWC04fYGfCe4u5gB/n3gDNoY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=XlvFYBUJ; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="XlvFYBUJ" Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55U7PgYh007537; Mon, 30 Jun 2025 09:53:57 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= wU4b/pQnY6PfcV136ZndGUeB/WVMZpBJ2uNidSqaKfU=; b=XlvFYBUJ8zEm1NxJ yzZ22zCKffPVgXkJ+VhVlfnzkcGwKwp2RXG6msNcfNt2RVkLFqgImggp5Xlrt26D AAusboM74tBSL59bIRlaaKwv0Sfkcg8VkLEvrmAxz64MGRl+QSrgxa+qWjQ/ZeTU ooDY7Ts9YmirFsH+Yr6SXInWj3RmQwqUDQCwgiul0n5DaIY1SwkWGjxJBOmYkmCN tHuwSanEJJ7Otem91wMMGH8SzYzVRFn+FkXKr5nPbtjq9fa5lF81lRcpLD8+u9Ug G7ax+VAlGFCfr2vlRecVN1KxRKqBS2lzAp2HzGz0M839Tqt4kA9hMgF8iqCBeRqw gSkRxw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 47jsy4ku6v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jun 2025 09:53:57 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 62F6840054; Mon, 30 Jun 2025 09:52:34 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 000385C2DE5; Mon, 30 Jun 2025 09:51:40 +0200 (CEST) Received: from gnbcxd0016.gnb.st.com (10.130.77.119) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 30 Jun 2025 09:51:40 +0200 Date: Mon, 30 Jun 2025 09:51:38 +0200 From: Alain Volmat To: =?iso-8859-1?Q?Cl=E9ment?= Le Goffic CC: Pierre-Yves MORDRET , Andi Shyti , Maxime Coquelin , Alexandre Torgue , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , M'boumba Cedric Madianga , Wolfram Sang , "Pierre-Yves MORDRET" , , , , , , , Subject: Re: [PATCH v2 2/3] i2c: stm32f7: unmap DMA mapped buffer Message-ID: <20250630075138.GB396213@gnbcxd0016.gnb.st.com> References: <20250627-i2c-upstream-v2-0-8c14523481dc@foss.st.com> <20250627-i2c-upstream-v2-2-8c14523481dc@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250627-i2c-upstream-v2-2-8c14523481dc@foss.st.com> X-Disclaimer: ce message est personnel / this message is private X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-30_01,2025-06-27_01,2025-03-28_01 Hello Clément, On Fri, Jun 27, 2025 at 12:12:57PM +0200, Clément Le Goffic wrote: > Fix an issue where the mapped DMA buffer was not unmapped. > > Fixes: 7ecc8cfde553 ("i2c: i2c-stm32f7: Add DMA support") > Signed-off-by: Clément Le Goffic > --- > drivers/i2c/busses/i2c-stm32f7.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index e4aaeb2262d0..042386b4cabe 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -1554,6 +1554,8 @@ static irqreturn_t stm32f7_i2c_handle_isr_errs(struct stm32f7_i2c_dev *i2c_dev, > if (i2c_dev->use_dma) { > stm32f7_i2c_disable_dma_req(i2c_dev); > dmaengine_terminate_async(dma->chan_using); > + dma_unmap_single(i2c_dev->dev, dma->dma_buf, dma->dma_len, > + dma->dma_data_dir); > } > > i2c_dev->master_mode = false; > @@ -1622,6 +1624,8 @@ static irqreturn_t stm32f7_i2c_isr_event_thread(int irq, void *data) > if (i2c_dev->use_dma) { > stm32f7_i2c_disable_dma_req(i2c_dev); > dmaengine_terminate_async(dma->chan_using); > + dma_unmap_single(i2c_dev->dev, dma->dma_buf, dma->dma_len, > + dma->dma_data_dir); > } > f7_msg->result = -ENXIO; > } > @@ -1642,6 +1646,8 @@ static irqreturn_t stm32f7_i2c_isr_event_thread(int irq, void *data) > dev_dbg(i2c_dev->dev, "<%s>: Timed out\n", __func__); > stm32f7_i2c_disable_dma_req(i2c_dev); > dmaengine_terminate_async(dma->chan_using); > + dma_unmap_single(i2c_dev->dev, dma->dma_buf, dma->dma_len, > + dma->dma_data_dir); > f7_msg->result = -ETIMEDOUT; > } > } > Thanks for the update. Looks good to me. Acked-by: Alain Volmat Regards, Alain > -- > 2.43.0 >