From: "Onur Özkan" <work@onurozkan.dev>
To: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com
Cc: airlied@gmail.com, simona@ffwll.ch, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
rafael@kernel.org, viresh.kumar@linaro.org,
gregkh@linuxfoundation.org, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, davidgow@google.com,
nm@ti.com, "Onur Özkan" <work@onurozkan.dev>
Subject: [PATCH v4 2/6] rust: switch to `#[expect(...)]` in init and kunit
Date: Tue, 1 Jul 2025 08:35:53 +0300 [thread overview]
Message-ID: <20250701053557.20859-3-work@onurozkan.dev> (raw)
In-Reply-To: <20250701053557.20859-1-work@onurozkan.dev>
This makes it clear that the warning is expected not just
ignored, so we don't end up having various unnecessary
linting rules in the codebase.
Some parts of the codebase already use this approach, this
patch just applies it more broadly.
No functional changes.
Signed-off-by: Onur Özkan <work@onurozkan.dev>
---
rust/kernel/init.rs | 6 +++---
rust/kernel/kunit.rs | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/rust/kernel/init.rs b/rust/kernel/init.rs
index 8d228c237954..288b1c2a290d 100644
--- a/rust/kernel/init.rs
+++ b/rust/kernel/init.rs
@@ -30,7 +30,7 @@
//! ## General Examples
//!
//! ```rust,ignore
-//! # #![allow(clippy::disallowed_names)]
+//! # #![expect(clippy::disallowed_names)]
//! use kernel::types::Opaque;
//! use pin_init::pin_init_from_closure;
//!
@@ -67,11 +67,11 @@
//! ```
//!
//! ```rust,ignore
-//! # #![allow(unreachable_pub, clippy::disallowed_names)]
+//! # #![expect(unreachable_pub, clippy::disallowed_names)]
//! use kernel::{prelude::*, types::Opaque};
//! use core::{ptr::addr_of_mut, marker::PhantomPinned, pin::Pin};
//! # mod bindings {
-//! # #![allow(non_camel_case_types)]
+//! # #![expect(non_camel_case_types)]
//! # pub struct foo;
//! # pub unsafe fn init_foo(_ptr: *mut foo) {}
//! # pub unsafe fn destroy_foo(_ptr: *mut foo) {}
diff --git a/rust/kernel/kunit.rs b/rust/kernel/kunit.rs
index 4b8cdcb21e77..91710a1d7b87 100644
--- a/rust/kernel/kunit.rs
+++ b/rust/kernel/kunit.rs
@@ -280,7 +280,7 @@ macro_rules! kunit_unsafe_test_suite {
static mut KUNIT_TEST_SUITE: ::kernel::bindings::kunit_suite =
::kernel::bindings::kunit_suite {
name: KUNIT_TEST_SUITE_NAME,
- #[allow(unused_unsafe)]
+ #[expect(unused_unsafe)]
// SAFETY: `$test_cases` is passed in by the user, and
// (as documented) must be valid for the lifetime of
// the suite (i.e., static).
--
2.50.0
next prev parent reply other threads:[~2025-07-01 5:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 5:35 [PATCH v4 0/6] replace `allow(...)` lints with `expect(...)` Onur Özkan
2025-07-01 5:35 ` [PATCH v4 1/6] rust: switch to `#[expect(...)]` in core modules Onur Özkan
2025-07-09 2:33 ` Trevor Gross
2025-07-01 5:35 ` Onur Özkan [this message]
2025-07-02 18:47 ` [PATCH v4 2/6] rust: switch to `#[expect(...)]` in init and kunit Benno Lossin
2025-07-07 13:02 ` Miguel Ojeda
2025-07-07 15:27 ` Benno Lossin
2025-07-09 2:39 ` Trevor Gross
2025-07-01 5:35 ` [PATCH v4 3/6] drivers: gpu: switch to `#[expect(...)]` in nova-core/regs.rs Onur Özkan
2025-07-09 2:42 ` Trevor Gross
2025-07-01 5:35 ` [PATCH v4 4/6] rust: switch to `#[expect(...)]` in devres, driver and ioctl Onur Özkan
2025-07-01 5:35 ` [PATCH v4 5/6] rust: remove `#[allow(clippy::unnecessary_cast)]` Onur Özkan
2025-07-09 2:37 ` Trevor Gross
2025-07-01 5:35 ` [PATCH v4 6/6] rust: remove `#[allow(clippy::non_send_fields_in_send_ty)]` Onur Özkan
2025-07-01 8:46 ` Miguel Ojeda
2025-07-01 8:43 ` [PATCH v4 0/6] replace `allow(...)` lints with `expect(...)` Miguel Ojeda
2025-07-01 17:27 ` Onur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701053557.20859-3-work@onurozkan.dev \
--to=work@onurozkan.dev \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=davidgow@google.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®