From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E92726F471 for ; Tue, 1 Jul 2025 10:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751367499; cv=none; b=ghzBGK1xDwjxKQyyka3KxFu+n3KrUcDqjvy28wMfVgdO4K5QgfwNs+bK+3qVeQGUS+SLt9QYhbjZO6NeqSsgaDi7HhLwdHDDURVEGyWZe39VYTdOB7wSsqShAs192MdeOcT2slx7GX8fqLSySQVyoAFpuGxvXVwFX7bqHRPsDdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751367499; c=relaxed/simple; bh=fevrYmYKDOiJ2smfFONJqA3GH4hDj/8aAOo/6KjTtkI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bLuyN7KpXlWz0h+BV2PHLvA4uiLbpOYzTrlwSG1yB561sOKt3y0YPE0i+hyMCD8IgfVlfA4sC+KjN61aXQnraAdI8t+VP6cAtKDD/glo75O5UohvjZz9zSL+CbmxOPT4JeYcMHd4QM0w8cAcJfmw0iLCjY5IrdoMgwWNPshtM48= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Yj3ni6pm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Yj3ni6pm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB174C4CEEB; Tue, 1 Jul 2025 10:58:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751367496; bh=fevrYmYKDOiJ2smfFONJqA3GH4hDj/8aAOo/6KjTtkI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yj3ni6pmbztQxjncDscxzlfllX1jePVP447M+Ruz72SpzDZoEGlt/kfbGY1gJVWM6 iqng2cK0+CgpY9W+FVQIqFG8W0OEY6ZP+XJ7tIebCVrbWw0Hw4w1CE/leCG246QBh6 jocETkmJQ+njPSrX27y+kuAMOJ7rIu5dd7awjK2gKLJNyIvr9IFloIKBC8BuqM0n9q L+kYQ5W/xnsrb+6x+BUQbyTXXz7JLKRKXA+P34gavMdIXbbaBHU0N6+oHnR2XbH4FG Qf5cnw3kNtClk0elPte1ElT5DijShDcwdjBDaKuhQB6XVSWi4oJ4sAAHvb+zqnOrW5 3m53dPNpajr9Q== Date: Tue, 1 Jul 2025 11:58:11 +0100 From: Lee Jones To: Dmitry Torokhov Cc: Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado , Fabien Parent , Reported-by: Louis-Alexis Eyraud , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org; Subject: Re: [PATCH] MFD: mt6397: do not use generic name for keypad sub-devices Message-ID: <20250701105811.GI10134@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, 30 Jun 2025, Dmitry Torokhov wrote: > Do not use "mtk-pmic-keys" when creating sub-device for the keypad to > make sure the keypad driver will only bind to the sub-device if it has > support for the variant/has matching compatible. > > Reported-by: Louis-Alexis Eyraud > Fixes: 6e31bb8d3a63 ("mfd: mt6397: Add initial support for MT6328") > Fixes: de58cee8c6b8 ("mfd: mt6397-core: Add MT6357 PMIC support") > Fixes: 4a901e305011 ("mfd: mt6397-core: Add resources for PMIC keys for MT6359") > Cc: stable@vger.kernel.org > Signed-off-by: Dmitry Torokhov > --- > > This is not tested so if someone with hardware could try it out that > would be great. I *think* it should work... My suspicion is that this will not work. Providing compatible strings here is only for device to node matching. I do not believe the drivers will probe using them. You don't need H/W to test this theory. You can just feed in a DTB and see if it probes. QEMU should be good enough for this. > drivers/mfd/mt6397-core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 5f8ed8988907..3e58d0764c7e 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c > @@ -136,7 +136,7 @@ static const struct mfd_cell mt6323_devs[] = { > .name = "mt6323-led", > .of_compatible = "mediatek,mt6323-led" > }, { > - .name = "mtk-pmic-keys", > + .name = "mt6323-keys", > .num_resources = ARRAY_SIZE(mt6323_keys_resources), > .resources = mt6323_keys_resources, > .of_compatible = "mediatek,mt6323-keys" > @@ -153,7 +153,7 @@ static const struct mfd_cell mt6328_devs[] = { > .name = "mt6328-regulator", > .of_compatible = "mediatek,mt6328-regulator" > }, { > - .name = "mtk-pmic-keys", > + .name = "mt6328-keys", > .num_resources = ARRAY_SIZE(mt6328_keys_resources), > .resources = mt6328_keys_resources, > .of_compatible = "mediatek,mt6328-keys" > @@ -175,7 +175,7 @@ static const struct mfd_cell mt6357_devs[] = { > .name = "mt6357-sound", > .of_compatible = "mediatek,mt6357-sound" > }, { > - .name = "mtk-pmic-keys", > + .name = "mt6357-keys", > .num_resources = ARRAY_SIZE(mt6357_keys_resources), > .resources = mt6357_keys_resources, > .of_compatible = "mediatek,mt6357-keys" > @@ -196,7 +196,7 @@ static const struct mfd_cell mt6331_mt6332_devs[] = { > .name = "mt6332-regulator", > .of_compatible = "mediatek,mt6332-regulator" > }, { > - .name = "mtk-pmic-keys", > + .name = "mt6331-keys", > .num_resources = ARRAY_SIZE(mt6331_keys_resources), > .resources = mt6331_keys_resources, > .of_compatible = "mediatek,mt6331-keys" > @@ -240,7 +240,7 @@ static const struct mfd_cell mt6359_devs[] = { > }, > { .name = "mt6359-sound", }, > { > - .name = "mtk-pmic-keys", > + .name = "mt6359-keys", > .num_resources = ARRAY_SIZE(mt6359_keys_resources), > .resources = mt6359_keys_resources, > .of_compatible = "mediatek,mt6359-keys" > @@ -272,7 +272,7 @@ static const struct mfd_cell mt6397_devs[] = { > .name = "mt6397-pinctrl", > .of_compatible = "mediatek,mt6397-pinctrl", > }, { > - .name = "mtk-pmic-keys", > + .name = "mt6397-keys", > .num_resources = ARRAY_SIZE(mt6397_keys_resources), > .resources = mt6397_keys_resources, > .of_compatible = "mediatek,mt6397-keys" > -- > 2.50.0.727.gbf7dc18ff4-goog > > > -- > Dmitry -- Lee Jones [李琼斯]