From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Simon Horman <horms@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
thomas.petazzoni@bootlin.com, "Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Marek Behún" <kabel@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
mwojtas@chromium.org, "Antoine Tenart" <atenart@kernel.org>,
devicetree@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>
Subject: Re: [PATCH net-next v7 04/15] net: phy: Introduce PHY ports representation
Date: Tue, 1 Jul 2025 15:06:31 +0200 [thread overview]
Message-ID: <20250701150631.0256539b@fedora.home> (raw)
In-Reply-To: <20250701130243.GA130037@horms.kernel.org>
On Tue, 1 Jul 2025 14:02:43 +0100
Simon Horman <horms@kernel.org> wrote:
> On Mon, Jun 30, 2025 at 04:33:03PM +0200, Maxime Chevallier wrote:
>
> ...
>
> > +/**
> > + * phy_port_get_type() - get the PORT_* attribut for that port.
> > + * @port: The port we want the information from
> > + *
> > + * Returns: A PORT_XXX value.
> > + */
> > +int phy_port_get_type(struct phy_port *port)
> > +{
> > + if (port->mediums & ETHTOOL_LINK_MEDIUM_BASET)
>
> Hi Maxime,
>
> Should this be:
>
> if (port->mediums & BIT(ETHTOOL_LINK_MEDIUM_BASET))
>
> Flagged by Smatch (because ETHTOOL_LINK_MEDIUM_BASET is 0,
> so as-is the condition is always false).
You're absolutely correct ! Thanks...
Maxime
next prev parent reply other threads:[~2025-07-01 13:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 14:32 [PATCH net-next v7 00/15] " Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 01/15] dt-bindings: net: Introduce the ethernet-connector description Maxime Chevallier
2025-07-08 15:57 ` Rob Herring
2025-07-09 6:36 ` Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 02/15] net: ethtool: common: Indicate that BaseT works on up to 4 lanes Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 03/15] net: ethtool: Introduce ETHTOOL_LINK_MEDIUM_* values Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 04/15] net: phy: Introduce PHY ports representation Maxime Chevallier
2025-07-01 13:02 ` Simon Horman
2025-07-01 13:06 ` Maxime Chevallier [this message]
2025-07-14 19:08 ` Dan Carpenter
2025-06-30 14:33 ` [PATCH net-next v7 05/15] net: phy: dp83822: Add support for phy_port representation Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 06/15] net: phy: Create a phy_port for PHY-driven SFPs Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 07/15] net: phy: Introduce generic SFP handling for PHY drivers Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 08/15] net: phy: marvell-88x2222: Support SFP through phy_port interface Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 09/15] net: phy: marvell: " Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 10/15] net: phy: marvell10g: Support SFP through phy_port Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 11/15] net: phy: at803x: Support SFP through phy_port interface Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 12/15] net: phy: qca807x: " Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 13/15] net: phy: Only rely on phy_port for PHY-driven SFP Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 14/15] net: phy: dp83822: Add SFP support through the phy_port interface Maxime Chevallier
2025-06-30 14:33 ` [PATCH net-next v7 15/15] Documentation: networking: Document the phy_port infrastructure Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701150631.0256539b@fedora.home \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mwojtas@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®