From: Nam Cao <namcao@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Gabriele Monaco <gmonaco@redhat.com>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
john.ogness@linutronix.de
Subject: Re: [PATCH v10 17/19] rv: Add rtapp_sleep monitor
Date: Tue, 1 Jul 2025 23:03:38 +0200 [thread overview]
Message-ID: <20250701210338.BooVbo54@linutronix.de> (raw)
In-Reply-To: <20250701111704.00456667@batman.local.home>
On Tue, Jul 01, 2025 at 11:17:04AM -0400, Steven Rostedt wrote:
> On Tue, 1 Jul 2025 17:11:14 +0200
> Nam Cao <namcao@linutronix.de> wrote:
>
> > > There's nothing in the code that even states that this was generated
> > > (if they were).
> >
> > Yeah this entire file is generated from the LTL specification. I will add a
> > comment.
>
> Yeah, generated code needs a big comment at the top of the file on what
> generated it.
Sure.
> Bonus points if it shows how it was generated so that people will know
> how to regenerate it.
If it's okay, not in this series. It requires changes to the RV core
script, and I prefer not touching things which are not LTL-specific for
now, unless necessary. The DA monitors and the containers do not have it as
well.
Let me stash it into my TODO list of RV cleanups. I will add this for LTL,
deterministic automaton and container in one go.
Best regards,
Nam
next prev parent reply other threads:[~2025-07-01 21:03 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 9:43 [PATCH v10 00/19] RV: Linear temporal logic monitors for RT application Nam Cao
2025-06-10 9:43 ` [PATCH v10 01/19] rv: Add #undef TRACE_INCLUDE_FILE Nam Cao
2025-06-10 9:43 ` [PATCH v10 02/19] printk: Make vprintk_deferred() public Nam Cao
2025-06-10 9:43 ` [PATCH v10 03/19] panic: Add vpanic() Nam Cao
2025-06-10 9:43 ` [PATCH v10 04/19] rv: Let the reactors take care of buffers Nam Cao
2025-06-10 9:43 ` [PATCH v10 05/19] verification/dot2k: Make a separate dot2k_templates/Kconfig_container Nam Cao
2025-06-10 9:43 ` [PATCH v10 06/19] verification/dot2k: Remove __buff_to_string() Nam Cao
2025-06-10 9:43 ` [PATCH v10 07/19] verification/dot2k: Replace is_container() hack with subparsers Nam Cao
2025-06-10 9:43 ` [PATCH v10 08/19] rv: rename CONFIG_DA_MON_EVENTS to CONFIG_RV_MON_EVENTS Nam Cao
2025-06-10 9:43 ` [PATCH v10 09/19] verification/dot2k: Prepare the frontend for LTL inclusion Nam Cao
2025-06-10 9:43 ` [PATCH v10 10/19] Documentation/rv: Prepare monitor synthesis document " Nam Cao
2025-06-10 9:43 ` [PATCH v10 11/19] verification/rvgen: Restructure the templates files Nam Cao
2025-06-10 9:43 ` [PATCH v10 12/19] verification/rvgen: Restructure the classes to prepare for LTL inclusion Nam Cao
2025-06-10 9:43 ` [PATCH v10 13/19] rv: Add support for LTL monitors Nam Cao
2025-06-30 19:17 ` Steven Rostedt
2025-06-10 9:43 ` [PATCH v10 14/19] rv: Add rtapp container monitor Nam Cao
2025-06-30 20:04 ` Steven Rostedt
2025-07-01 5:21 ` Nam Cao
2025-06-10 9:43 ` [PATCH v10 15/19] riscv: mm: Add page fault trace points Nam Cao
2025-06-23 23:37 ` Palmer Dabbelt
2025-06-10 9:43 ` [PATCH v10 16/19] rv: Add rtapp_pagefault monitor Nam Cao
2025-06-30 23:59 ` Steven Rostedt
2025-06-10 9:43 ` [PATCH v10 17/19] rv: Add rtapp_sleep monitor Nam Cao
2025-07-01 0:34 ` Steven Rostedt
2025-07-01 5:17 ` Nam Cao
2025-07-01 15:02 ` Steven Rostedt
2025-07-01 15:05 ` Steven Rostedt
2025-07-01 15:11 ` Nam Cao
2025-07-01 15:17 ` Steven Rostedt
2025-07-01 21:03 ` Nam Cao [this message]
2025-07-01 21:17 ` Steven Rostedt
2025-07-02 6:29 ` Gabriele Monaco
2025-07-08 7:50 ` Nam Cao
2025-07-08 11:57 ` Gabriele Monaco
2025-06-10 9:43 ` [PATCH v10 18/19] rv: Add documentation for rtapp monitor Nam Cao
2025-07-01 0:34 ` Steven Rostedt
2025-06-10 9:43 ` [PATCH v10 19/19] rv: Allow to configure the number of per-task monitor Nam Cao
2025-06-27 12:42 ` [PATCH v10 00/19] RV: Linear temporal logic monitors for RT application Nam Cao
2025-06-27 14:16 ` Steven Rostedt
2025-06-27 14:17 ` Nam Cao
2025-07-01 0:37 ` Steven Rostedt
2025-07-01 5:26 ` Nam Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701210338.BooVbo54@linutronix.de \
--to=namcao@linutronix.de \
--cc=gmonaco@redhat.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®