mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Wladislav Wiebe <wladislav.wiebe@nokia.com>
Cc: anna-maria@linutronix.de, frederic@kernel.org, mingo@kernel.org,
	tglx@linutronix.de, akpm@linux-foundation.org,
	bigeasy@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irq: add support for warning on long-running IRQ handlers
Date: Wed, 2 Jul 2025 11:06:14 +0200	[thread overview]
Message-ID: <20250702090614.GP1613200@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <c77690ff-9f3d-4ab8-9443-b377134e90ca@nokia.com>

On Mon, Jun 30, 2025 at 03:59:17PM +0200, Wladislav Wiebe wrote:
> 
> On 30/06/2025 15:25, Peter Zijlstra wrote:
> > CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
> >
> >
> >
> > On Mon, Jun 30, 2025 at 02:46:44PM +0200, Wladislav Wiebe wrote:
> >> Introduce a new option CONFIG_IRQ_LATENCY_WARN that enables warnings when
> >> IRQ handlers take an unusually long time to execute.
> >>
> >> When triggered, the warning includes the CPU, IRQ number, handler address,
> >> name, and execution duration, for example:
> >>
> >>   [CPU0] latency on IRQ[787:bad_irq_handler+0x1/0x34 [bad_irq]], took: 5 jiffies (~50 ms)
> >>
> >> To keep runtime overhead minimal, this implementation uses a jiffies-based
> >> timing mechanism. While coarse, it is sufficient to detect problematic IRQs.
> > local_clock() was found to be excessively expensive?
> 
> Perhaps not excessively expensive, but jiffies is the lowest-overhead option here, isn't it?

Yeah, but since it varies in length and even the shortest (1ms) might be
too long for some, it is of very limited use.

  reply	other threads:[~2025-07-02  9:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-30 12:46 Wladislav Wiebe
2025-06-30 13:25 ` Peter Zijlstra
2025-06-30 13:59   ` Wladislav Wiebe
2025-07-02  9:06     ` Peter Zijlstra [this message]
2025-07-02  9:14       ` Wladislav Wiebe
2025-06-30 15:42 ` Thomas Gleixner
2025-07-01  6:10   ` Wladislav Wiebe
2025-07-01  7:37     ` Thomas Gleixner
2025-07-15  8:23       ` Wladislav Wiebe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250702090614.GP1613200@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=anna-maria@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wladislav.wiebe@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®