From: Leo Yan <leo.yan@arm.com>
To: Junhao He <hejunhao3@huawei.com>
Cc: suzuki.poulose@arm.com, james.clark@arm.com,
anshuman.khandual@arm.com, coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
jonathan.cameron@huawei.com, yangyicong@huawei.com,
prime.zeng@hisilicon.com
Subject: Re: [PATCH v2 3/3] coresight: tmc: Decouple the perf buffer allocation from sysfs mode
Date: Wed, 2 Jul 2025 18:08:27 +0100 [thread overview]
Message-ID: <20250702170827.GB1039028@e132581.arm.com> (raw)
In-Reply-To: <20250620075412.952934-4-hejunhao3@huawei.com>
On Fri, Jun 20, 2025 at 03:54:12PM +0800, Junhao He wrote:
[..]
> @@ -1341,33 +1339,24 @@ alloc_etr_buf(struct tmc_drvdata *drvdata, struct perf_event *event,
> unsigned long size;
>
> node = (event->cpu == -1) ? NUMA_NO_NODE : cpu_to_node(event->cpu);
> - /*
> - * Try to match the perf ring buffer size if it is larger
> - * than the size requested via sysfs.
> - */
> - if ((nr_pages << PAGE_SHIFT) > drvdata->size) {
> - etr_buf = tmc_alloc_etr_buf(drvdata, ((ssize_t)nr_pages << PAGE_SHIFT),
> - 0, node, NULL);
> - if (!IS_ERR(etr_buf))
> - goto done;
> - }
> +
> + /* Use the minimum limit if the required size is smaller */
> + size = (unsigned long)nr_pages << PAGE_SHIFT;
Please change the size's type to ssize_t, then:
size = nr_pages << PAGE_SHIFT;
> + if (size < TMC_ETR_PERF_MIN_BUF_SIZE)
> + size = TMC_ETR_PERF_MIN_BUF_SIZE;
size = min_t(ssize_t, size, TMC_ETR_PERF_MIN_BUF_SIZE);
>
> /*
> - * Else switch to configured size for this ETR
> - * and scale down until we hit the minimum limit.
> + * Try to allocate the required size for this ETR, if failed scale
> + * down until we hit the minimum limit.
> */
> - size = drvdata->size;
> do {
> etr_buf = tmc_alloc_etr_buf(drvdata, size, 0, node, NULL);
> if (!IS_ERR(etr_buf))
> - goto done;
> + return etr_buf;
> size /= 2;
> } while (size >= TMC_ETR_PERF_MIN_BUF_SIZE);
Do we really need to scale down buffer size for failure cases?
I would like a straightforward code:
etr_buf = tmc_alloc_etr_buf(drvdata, size, 0, node, NULL);
if (IS_ERR_OR_NULL(etr_buf))
return etr_buf;
Just a side topic, we know tmc_alloc_etr_buf() should not return NULL
pointer. For a sanity check, the callers (alloc_etr_buf(),
tmc_etr_get_sysfs_buffer(), etc) should valid a buffer pointer with
IS_ERR_OR_NULL() rather than IS_ERR(). This can be a separate patch.
Thanks,
Leo
> return ERR_PTR(-ENOMEM);
> -
> -done:
> - return etr_buf;
> }
>
> static struct etr_buf *
> --
> 2.33.0
>
next prev parent reply other threads:[~2025-07-02 17:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 7:54 [PATCH v2 0/3] Coresight TMC-ETR some bugfixes and cleanups Junhao He
2025-06-20 7:54 ` [PATCH v2 1/3] coresight: tmc: Add missing doc of tmc_drvdata::reading Junhao He
2025-06-20 11:53 ` Jonathan Cameron
2025-07-01 13:38 ` hejunhao
2025-07-02 15:27 ` Leo Yan
2025-07-19 11:05 ` hejunhao
2025-06-20 7:54 ` [PATCH v2 2/3] coresight: tmc: refactor the tmc-etr mode setting to avoid race conditions Junhao He
2025-06-20 12:45 ` Jonathan Cameron
2025-07-01 13:35 ` hejunhao
2025-07-02 16:47 ` Leo Yan
2025-07-19 11:09 ` hejunhao
2025-06-20 7:54 ` [PATCH v2 3/3] coresight: tmc: Decouple the perf buffer allocation from sysfs mode Junhao He
2025-07-02 17:08 ` Leo Yan [this message]
2025-07-19 11:20 ` hejunhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702170827.GB1039028@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=coresight@lists.linaro.org \
--cc=hejunhao3@huawei.com \
--cc=james.clark@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=prime.zeng@hisilicon.com \
--cc=suzuki.poulose@arm.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®