From: Joel Fernandes <joelagnelf@nvidia.com>
To: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>
Cc: Joel Fernandes <joelagnelf@nvidia.com>, Tejun Heo <tj@kernel.org>,
David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>
Subject: [PATCH v6 05/14] sched/deadline: Return EBUSY if dl_bw_cpus is zero
Date: Wed, 2 Jul 2025 19:29:30 -0400 [thread overview]
Message-ID: <20250702232944.3221001-6-joelagnelf@nvidia.com> (raw)
In-Reply-To: <20250702232944.3221001-1-joelagnelf@nvidia.com>
Hotplugged CPUs coming online do an enqueue but are not a part of any
root domain containing cpu_active() CPUs. So in this case, don't mess
with accounting and we can retry later. Without this patch, we see
crashes with sched_ext selftest's hotplug test due to divide by zero.
Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
---
kernel/sched/deadline.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 7129b61d548b..0e73577257ad 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1725,7 +1725,12 @@ int dl_server_apply_params(struct sched_dl_entity *dl_se, u64 runtime, u64 perio
cpus = dl_bw_cpus(cpu);
cap = dl_bw_capacity(cpu);
- if (__dl_overflow(dl_b, cap, old_bw, new_bw))
+ /*
+ * Hotplugged CPUs coming online do an enqueue but are not a part of any
+ * root domain containing cpu_active() CPUs. So in this case, don't mess
+ * with accounting and we can retry later.
+ */
+ if (!cpus || __dl_overflow(dl_b, cap, old_bw, new_bw))
return -EBUSY;
if (init) {
--
2.34.1
next prev parent reply other threads:[~2025-07-02 23:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 23:29 [PATCH v6 00/14] Add a deadline server for sched_ext tasks Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 01/14] sched/debug: Fix updating of ppos on server write ops Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 02/14] sched/debug: Stop and start server based on if it was active Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 03/14] sched/deadline: Clear the defer params Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 04/14] sched/deadline: Prevent setting server as started if params couldn't be applied Joel Fernandes
2025-07-02 23:29 ` Joel Fernandes [this message]
2025-07-17 15:51 ` [PATCH v6 05/14] sched/deadline: Return EBUSY if dl_bw_cpus is zero Andrea Righi
2025-07-02 23:29 ` [PATCH v6 06/14] sched: Add support to pick functions to take rf Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 07/14] sched: Add a server arg to dl_server_update_idle_time() Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 08/14] sched/ext: Add a DL server for sched_ext tasks Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 09/14] sched/debug: Add support to change sched_ext server params Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 10/14] sched/deadline: Add support to remove DLserver's bandwidth contribution Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 11/14] sched/ext: Relinquish DL server reservations when not needed Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 12/14] selftests/sched_ext: Add test for sched_ext dl_server Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 13/14] sched/deadline: Fix DL server crash in inactive_timer callback Joel Fernandes
2025-07-02 23:29 ` [PATCH v6 14/14] selftests/sched_ext: Add test for DL server total_bw consistency Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702232944.3221001-6-joelagnelf@nvidia.com \
--to=joelagnelf@nvidia.com \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®