From: Greg KH <gregkh@linuxfoundation.org>
To: Brahmajit Das <listout@listout.xyz>
Cc: linux-kernel@vger.kernel.org, alexander.usyskin@intel.com,
tomas.winkler@intel.com
Subject: Re: [PATCH] samples: mei: Fix building on musl libc
Date: Wed, 2 Jul 2025 07:45:35 +0200 [thread overview]
Message-ID: <2025070224-unheard-viscous-58a5@gregkh> (raw)
In-Reply-To: <20250701160726.22406-1-listout@listout.xyz>
On Tue, Jul 01, 2025 at 09:37:26PM +0530, Brahmajit Das wrote:
> The header bits/wordsize.h is glibc specific and on building on musl
> with allyesconfig results in
>
> samples/mei/mei-amt-version.c:77:10: fatal error: bits/wordsize.h: No such file or directory
> 77 | #include <bits/wordsize.h>
> | ^~~~~~~~~~~~~~~~~
>
> mei-amt-version.c build file without bits/wordsize.h on musl and glibc.
>
> However on musl we get the follwing error without sys/time.h
>
> samples/mei/mei-amt-version.c: In function 'mei_recv_msg':
> samples/mei/mei-amt-version.c:159:24: error: storage size of 'tv' isn't known
> 159 | struct timeval tv;
> | ^~
> samples/mei/mei-amt-version.c:160:9: error: unknown type name 'fd_set'
> 160 | fd_set set;
> | ^~~~~~
> samples/mei/mei-amt-version.c:168:9: error: implicit declaration of function 'FD_ZERO' [-Wimplicit-function-declaration]
> 168 | FD_ZERO(&set);
> | ^~~~~~~
> samples/mei/mei-amt-version.c:169:9: error: implicit declaration of function 'FD_SET'; did you mean 'L_SET'? [-Wimplicit-function-declaration]
> 169 | FD_SET(me->fd, &set);
> | ^~~~~~
> | L_SET
> samples/mei/mei-amt-version.c:170:14: error: implicit declaration of function 'select' [-Wimplicit-function-declaration]
> 170 | rc = select(me->fd + 1, &set, NULL, NULL, &tv);
> | ^~~~~~
> samples/mei/mei-amt-version.c:171:23: error: implicit declaration of function 'FD_ISSET' [-Wimplicit-function-declaration]
> 171 | if (rc > 0 && FD_ISSET(me->fd, &set)) {
> | ^~~~~~~~
> samples/mei/mei-amt-version.c:159:24: warning: unused variable 'tv' [-Wunused-variable]
> 159 | struct timeval tv;
> | ^~
>
> Hence the the file has been included.
>
> Signed-off-by: Brahmajit Das <listout@listout.xyz>
> ---
> samples/mei/mei-amt-version.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
What commit id does this fix?
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-02 5:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 16:07 Brahmajit Das
2025-07-02 5:45 ` Greg KH [this message]
2025-07-02 11:47 ` Brahmajit Das
2025-07-02 12:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025070224-unheard-viscous-58a5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=listout@listout.xyz \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®