Re: [PATCH v2] net: ethernet: rtsn: Fix a null pointer dereference in rtsn_probe()

["Niklas Söderlund" <niklas.soderlund@ragnatech.se>]

Hi Haoxiang,

Thanks for your work.

On 2025-07-03 18:01:09 +0800, Haoxiang Li wrote:
> Add check for the return value of rcar_gen4_ptp_alloc()
> to prevent potential null pointer dereference.
> 
> Fixes: b0d3969d2b4d ("net: ethernet: rtsn: Add support for Renesas Ethernet-TSN")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
> Changes in v2:
> - Add a blank line to make the grouping similar to the
> style of other error checks in probe. Thanks, Niklas!
> ---
>  drivers/net/ethernet/renesas/rtsn.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/renesas/rtsn.c b/drivers/net/ethernet/renesas/rtsn.c
> index 6b3f7fca8d15..05c4b6c8c9c3 100644
> --- a/drivers/net/ethernet/renesas/rtsn.c
> +++ b/drivers/net/ethernet/renesas/rtsn.c
> @@ -1259,7 +1259,12 @@ static int rtsn_probe(struct platform_device *pdev)
>  	priv = netdev_priv(ndev);
>  	priv->pdev = pdev;
>  	priv->ndev = ndev;
> +
>  	priv->ptp_priv = rcar_gen4_ptp_alloc(pdev);
> +	if (!priv->ptp_priv) {
> +		ret = -ENOMEM;
> +		goto error_free;
> +	}
>  
>  	spin_lock_init(&priv->lock);
>  	platform_set_drvdata(pdev, priv);
> -- 
> 2.25.1
> 

-- 
Kind Regards,
Niklas Söderlund