mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Alex Elder <elder@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 47/80] net: ipa: Remove redundant pm_runtime_mark_last_busy() calls
Date: Fri,  4 Jul 2025 10:54:36 +0300	[thread overview]
Message-ID: <20250704075436.3220762-1-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20250704075225.3212486-1-sakari.ailus@linux.intel.com>

pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
The cover letter of the set can be found here
<URL:https://lore.kernel.org/linux-pm/20250704075225.3212486-1-sakari.ailus@linux.intel.com>.

In brief, this patch depends on PM runtime patches adding marking the last
busy timestamp in autosuspend related functions. The patches are here, on
rc2:

        git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
                pm-runtime-6.17-rc1

 drivers/net/ipa/ipa_interrupt.c | 1 -
 drivers/net/ipa/ipa_main.c      | 1 -
 drivers/net/ipa/ipa_modem.c     | 4 ----
 drivers/net/ipa/ipa_smp2p.c     | 2 --
 drivers/net/ipa/ipa_uc.c        | 2 --
 5 files changed, 10 deletions(-)

diff --git a/drivers/net/ipa/ipa_interrupt.c b/drivers/net/ipa/ipa_interrupt.c
index 245a06997055..8336596b1247 100644
--- a/drivers/net/ipa/ipa_interrupt.c
+++ b/drivers/net/ipa/ipa_interrupt.c
@@ -149,7 +149,6 @@ static irqreturn_t ipa_isr_thread(int irq, void *dev_id)
 		iowrite32(pending, ipa->reg_virt + reg_offset(reg));
 	}
 out_power_put:
-	pm_runtime_mark_last_busy(dev);
 	(void)pm_runtime_put_autosuspend(dev);
 
 	return IRQ_HANDLED;
diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
index f25f6e2cf58c..b37516de01fa 100644
--- a/drivers/net/ipa/ipa_main.c
+++ b/drivers/net/ipa/ipa_main.c
@@ -911,7 +911,6 @@ static int ipa_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_deconfig;
 done:
-	pm_runtime_mark_last_busy(dev);
 	(void)pm_runtime_put_autosuspend(dev);
 
 	return 0;
diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c
index 8fe0d0e1a00f..9b136f6b8b4a 100644
--- a/drivers/net/ipa/ipa_modem.c
+++ b/drivers/net/ipa/ipa_modem.c
@@ -71,7 +71,6 @@ static int ipa_open(struct net_device *netdev)
 
 	netif_start_queue(netdev);
 
-	pm_runtime_mark_last_busy(dev);
 	(void)pm_runtime_put_autosuspend(dev);
 
 	return 0;
@@ -102,7 +101,6 @@ static int ipa_stop(struct net_device *netdev)
 	ipa_endpoint_disable_one(priv->rx);
 	ipa_endpoint_disable_one(priv->tx);
 out_power_put:
-	pm_runtime_mark_last_busy(dev);
 	(void)pm_runtime_put_autosuspend(dev);
 
 	return 0;
@@ -175,7 +173,6 @@ ipa_start_xmit(struct sk_buff *skb, struct net_device *netdev)
 
 	ret = ipa_endpoint_skb_tx(endpoint, skb);
 
-	pm_runtime_mark_last_busy(dev);
 	(void)pm_runtime_put_autosuspend(dev);
 
 	if (ret) {
@@ -432,7 +429,6 @@ static void ipa_modem_crashed(struct ipa *ipa)
 		dev_err(dev, "error %d zeroing modem memory regions\n", ret);
 
 out_power_put:
-	pm_runtime_mark_last_busy(dev);
 	(void)pm_runtime_put_autosuspend(dev);
 }
 
diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
index fcaadd111a8a..420098796eec 100644
--- a/drivers/net/ipa/ipa_smp2p.c
+++ b/drivers/net/ipa/ipa_smp2p.c
@@ -171,7 +171,6 @@ static irqreturn_t ipa_smp2p_modem_setup_ready_isr(int irq, void *dev_id)
 	WARN(ret != 0, "error %d from ipa_setup()\n", ret);
 
 out_power_put:
-	pm_runtime_mark_last_busy(dev);
 	(void)pm_runtime_put_autosuspend(dev);
 
 	return IRQ_HANDLED;
@@ -213,7 +212,6 @@ static void ipa_smp2p_power_release(struct ipa *ipa)
 	if (!ipa->smp2p->power_on)
 		return;
 
-	pm_runtime_mark_last_busy(dev);
 	(void)pm_runtime_put_autosuspend(dev);
 	ipa->smp2p->power_on = false;
 }
diff --git a/drivers/net/ipa/ipa_uc.c b/drivers/net/ipa/ipa_uc.c
index 2963db83ab6b..dc7e92f2a4fb 100644
--- a/drivers/net/ipa/ipa_uc.c
+++ b/drivers/net/ipa/ipa_uc.c
@@ -158,7 +158,6 @@ static void ipa_uc_response_hdlr(struct ipa *ipa)
 		if (ipa->uc_powered) {
 			ipa->uc_loaded = true;
 			ipa_power_retention(ipa, true);
-			pm_runtime_mark_last_busy(dev);
 			(void)pm_runtime_put_autosuspend(dev);
 			ipa->uc_powered = false;
 		} else {
@@ -203,7 +202,6 @@ void ipa_uc_deconfig(struct ipa *ipa)
 	if (!ipa->uc_powered)
 		return;
 
-	pm_runtime_mark_last_busy(dev);
 	(void)pm_runtime_put_autosuspend(dev);
 }
 
-- 
2.39.5


  parent reply	other threads:[~2025-07-04  7:54 UTC|newest]

Thread overview: 165+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04  7:52 [PATCH 00/80] treewide: " Sakari Ailus
2025-07-04  7:53 ` [PATCH 01/80] accel/ivpu: " Sakari Ailus
2025-07-07  8:29   ` Jacek Lawrynowicz
2025-07-04  7:53 ` [PATCH 02/80] accel/amdxdna: " Sakari Ailus
2025-07-07 16:52   ` Lizhi Hou
2025-07-04  7:53 ` [PATCH 04/80] bus: sunxi-rsb: " Sakari Ailus
2025-07-15 16:33   ` Chen-Yu Tsai
2025-07-04  7:53 ` [PATCH 03/80] Bluetooth: " Sakari Ailus
2025-07-04  7:53 ` [PATCH 05/80] hwrng: " Sakari Ailus
2025-07-07  9:35   ` AngeloGioacchino Del Regno
2025-07-18 10:58   ` Herbert Xu
2025-07-04  7:54 ` [PATCH 06/80] clk: imx: " Sakari Ailus
2025-07-07  8:30   ` Peng Fan
2025-07-24 21:37   ` Stephen Boyd
2025-07-04  7:54 ` [PATCH 07/80] clk: qcom: " Sakari Ailus
2025-07-24 21:46   ` Stephen Boyd
2025-07-04  7:54 ` [PATCH 08/80] crypto: " Sakari Ailus
2025-07-18 10:59   ` Herbert Xu
2025-07-04  7:54 ` [PATCH 09/80] dmaengine: at_xdmac: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 10/80] dmaengine: pl330: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 12/80] dmaengine: ste_dma40: " Sakari Ailus
2025-07-04  8:41   ` Linus Walleij
2025-07-04  7:54 ` [PATCH 11/80] dmaengine: qcom: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 13/80] dmaengine: ti: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 14/80] dmaengine: zynqmp_dma: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 15/80] gpio: arizona: " Sakari Ailus
2025-07-07  8:46   ` Charles Keepax
2025-07-04  7:54 ` [PATCH 16/80] drm/amd: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 17/80] drm/nouveau: " Sakari Ailus
2025-07-04  9:24   ` Danilo Krummrich
2025-07-04  7:54 ` [PATCH 19/80] drm/panfrost: " Sakari Ailus
2025-07-04  9:18   ` Steven Price
2025-08-15 14:22     ` Steven Price
2025-07-04  7:54 ` [PATCH 18/80] drm/radeon: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 20/80] drivers: drm: " Sakari Ailus
2025-07-04  8:11   ` Jani Nikula
2025-07-04  8:58   ` Laurent Pinchart
2025-07-04  9:12   ` Thierry Reding
2025-07-04  9:18   ` Steven Price
2025-07-04 10:24   ` Maíra Canal
2025-07-08 14:01   ` Luca Ceresoli
2025-07-04  7:54 ` [PATCH 21/80] HSI: omap_ssi_port: " Sakari Ailus
2025-07-05  0:37   ` Sebastian Reichel
2025-07-04  7:54 ` [PATCH 22/80] stm class: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 23/80] i2c: " Sakari Ailus
2025-07-10 20:49   ` Andi Shyti
2025-10-14 11:52   ` Wolfram Sang
2025-07-04  7:54 ` [PATCH 24/80] i3c: master: svc: " Sakari Ailus
2025-07-15 14:00   ` Frank Li
2025-07-04  7:54 ` [PATCH 25/80] i3c: dw: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 27/80] iio: accel: " Sakari Ailus
2025-07-04  9:05   ` Jonathan Cameron
2025-07-10  6:46   ` Matti Vaittinen
2025-07-13 13:43     ` Jonathan Cameron
2025-07-04  7:54 ` [PATCH 26/80] HID: intel-thc-hid: " Sakari Ailus
2025-07-07  5:11   ` Xu, Even
2025-07-04  7:54 ` [PATCH 28/80] iio: adc: " Sakari Ailus
2025-07-04  8:42   ` Linus Walleij
2025-07-04  9:09   ` Jonathan Cameron
2025-07-04  7:54 ` [PATCH 29/80] iio: chemical: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 30/80] iio: common: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 32/80] iio: gyro: " Sakari Ailus
2025-07-04  8:41   ` Linus Walleij
2025-07-04 15:25   ` Rui Miguel Silva
2025-07-04  7:54 ` [PATCH 31/80] iio: dac: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 33/80] iio: imu: " Sakari Ailus
2025-07-04 10:26   ` Waqar Hameed
2025-07-04  7:54 ` [PATCH 34/80] iio: light: " Sakari Ailus
2025-07-04  8:42   ` Linus Walleij
2025-07-06 10:31   ` Jonathan Cameron
2025-07-04  7:54 ` [PATCH 35/80] iio: magnetometer: " Sakari Ailus
2025-07-04  8:43   ` Linus Walleij
2025-07-06 10:28   ` Jonathan Cameron
2025-07-04  7:54 ` [PATCH 36/80] iio: pressure: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 37/80] iio: proximity: " Sakari Ailus
2025-07-06 10:27   ` Jonathan Cameron
2025-07-04  7:54 ` [PATCH 39/80] Input: omap4-keypad: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 38/80] iio: temperature: " Sakari Ailus
2025-07-04 16:00   ` Crt Mori
2025-07-06 10:25     ` Jonathan Cameron
2025-07-06 10:26       ` Jonathan Cameron
2025-07-08 10:52         ` Sakari Ailus
2025-07-04  7:54 ` [PATCH 40/80] Input: cs40l50: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 41/80] media: " Sakari Ailus
2025-07-04  8:56   ` Laurent Pinchart
2025-07-04  9:07   ` Thierry Reding
2025-07-04  9:32   ` Tommaso Merciai
2025-07-04 11:30   ` Dikshita Agarwal
2025-07-04 15:16   ` Sean Young
2025-07-07 15:57   ` Dave Stevenson
2025-07-09  8:43   ` Benjamin Gaignard
2025-07-04  7:54 ` [PATCH 42/80] mfd: " Sakari Ailus
2025-07-07  8:47   ` Charles Keepax
2025-07-23  8:42   ` (subset) " Lee Jones
2025-07-04  7:54 ` [PATCH 43/80] mei: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 44/80] mmc: " Sakari Ailus
2025-07-09 14:02   ` Ulf Hansson
2025-07-04  7:54 ` [PATCH 45/80] mtd: rawnand: gpmi: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 46/80] net: ethernet: " Sakari Ailus
2025-07-04  8:57   ` Niklas Söderlund
2025-07-04  7:54 ` Sakari Ailus [this message]
2025-07-04  7:54 ` [PATCH 48/80] net: wireless: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 49/80] net: wwan: " Sakari Ailus
2025-07-05  9:51   ` Sergey Ryazanov
2025-07-04  7:54 ` [PATCH 50/80] nfc: trf7970a: " Sakari Ailus
2025-07-04  8:03   ` Krzysztof Kozlowski
2025-07-15  8:18     ` Sakari Ailus
2025-07-04  7:54 ` [PATCH 51/80] PCI/portdrv: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 52/80] phy: motorola: phy-mapphone-mdm6600: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 53/80] phy: ti: phy-twl4030-usb: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 54/80] power: supply: bq24190: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 55/80] power: supply: twl4030_charger: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 56/80] pwm: img: " Sakari Ailus
2025-07-09  8:55   ` Uwe Kleine-König
2025-07-04  7:54 ` [PATCH 57/80] regulator: stm32-vrefbuf: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 58/80] remoteproc: omap: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 60/80] soundwire: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 59/80] slimbus: " Sakari Ailus
2025-07-09  6:41   ` Srinivas Kandagatla
2025-07-04  7:54 ` [PATCH 61/80] spi: " Sakari Ailus
2025-07-07  9:35   ` AngeloGioacchino Del Regno
2025-07-04  7:54 ` [PATCH 62/80] staging: greybus: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 63/80] " Sakari Ailus
2025-07-04  7:54 ` [PATCH 64/80] media: rkvdec: " Sakari Ailus
2025-07-04 13:05   ` Nicolas Dufresne
2025-08-11 13:48   ` Nicolas Dufresne
2025-07-04  7:54 ` [PATCH 65/80] thunderbolt: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 66/80] serial: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 67/80] usb: " Sakari Ailus
2025-07-04  9:11   ` Thierry Reding
2025-07-07  9:35   ` AngeloGioacchino Del Regno
2025-07-21  2:25   ` Peter Chen (CIX)
2025-07-04  7:54 ` [PATCH 68/80] w1: omap-hdq: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 70/80] ASoC: atmel: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 69/80] ALSA: hda: " Sakari Ailus
2025-07-04 11:47   ` Takashi Iwai
2025-07-04 11:52     ` Mark Brown
2025-07-04 11:58       ` Takashi Iwai
2025-07-06  8:27         ` Takashi Iwai
2025-07-04  7:54 ` [PATCH 71/80] ASoC: codecs: " Sakari Ailus
2025-07-07  9:16   ` Charles Keepax
2025-07-04  7:54 ` [PATCH 72/80] ASoC: Intel: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 73/80] ASoC: component: " Sakari Ailus
2025-07-04  7:54 ` [PATCH 74/80] ASoC: SOF: " Sakari Ailus
2025-07-04  8:26   ` Péter Ujfalusi
2025-07-04  7:55 ` [PATCH 76/80] soc: apple: mailbox: " Sakari Ailus
2025-07-04  7:55 ` [PATCH 75/80] ALSA: intel_hdmi: " Sakari Ailus
2025-07-04 11:45   ` Takashi Iwai
2025-07-06  8:26     ` Takashi Iwai
2025-07-04  7:55 ` [PATCH 77/80] block: pm: " Sakari Ailus
2025-07-07  5:59   ` Christoph Hellwig
2025-07-04  7:55 ` [PATCH 78/80] Input: cyapa - " Sakari Ailus
2025-07-04  7:55 ` [PATCH 80/80] scsi: block: pm: " Sakari Ailus
2025-07-04  7:55 ` [PATCH 79/80] mei: " Sakari Ailus
2025-07-04  9:03 ` [PATCH 00/80] treewide: " Jonathan Cameron
2025-07-04 12:04 ` Mark Brown
2025-07-08 10:01   ` Sakari Ailus
2025-07-04 18:15 ` (subset) " Mark Brown
2025-07-04 23:39 ` Mark Brown
2025-07-06 23:04 ` Sebastian Reichel
2025-07-07  8:03 ` Bartosz Golaszewski
2025-07-07 16:29 ` Mark Brown
2025-07-30 23:40 ` Alexandre Belloni
2025-09-05 21:08 ` Sebastian Reichel
2025-11-26 20:10 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250704075436.3220762-1-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=elder@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®