Re: [PATCH net 3/4] net: hns3: fixed vf get max channels bug

[Simon Horman <horms@kernel.org>]

+ David Laight

On Wed, Jul 02, 2025 at 09:09:00PM +0800, Jijie Shao wrote:
> From: Hao Lan <lanhao@huawei.com>
> 
> Currently, the queried maximum of vf channels is the maximum of channels
> supported by each TC. However, the actual maximum of channels is
> the maximum of channels supported by the device.
> 
> Fixes: 849e46077689 ("net: hns3: add ethtool_ops.get_channels support for VF")
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> Signed-off-by: Hao Lan <lanhao@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>

> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> index 33136a1e02cf..626f5419fd7d 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> @@ -3094,11 +3094,7 @@ static void hclgevf_uninit_ae_dev(struct hnae3_ae_dev *ae_dev)
>  
>  static u32 hclgevf_get_max_channels(struct hclgevf_dev *hdev)
>  {
> -	struct hnae3_handle *nic = &hdev->nic;
> -	struct hnae3_knic_private_info *kinfo = &nic->kinfo;
> -
> -	return min_t(u32, hdev->rss_size_max,
> -		     hdev->num_tqps / kinfo->tc_info.num_tc);
> +	return min_t(u32, hdev->rss_size_max, hdev->num_tqps);

min_t() wasn't needed before and it certainly doesn't seem to be needed
now, as both .rss_size_max, and .num_tqps are u16.

As a follow-up, once this change hits net-next, please update to use min()
instead. Likely elsewhere too.