mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+32de323b0addb9e114ff@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [kernel?] UBSAN: shift-out-of-bounds in pcl812_attach
Date: Sat,  5 Jul 2025 07:45:32 +0800	[thread overview]
Message-ID: <20250704234551.2525-1-hdanton@sina.com> (raw)
In-Reply-To: <68684cb9.a00a0220.c7b3.0027.GAE@google.com>

> Date: Fri, 04 Jul 2025 14:50:49 -0700
> syzbot found the following issue on:
> 
> HEAD commit:    4c06e63b9203 Merge tag 'for-6.16-rc4-tag' of git://git.ker..
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=104a8f70580000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=b29b1a0d7330d4a8
> dashboard link: https://syzkaller.appspot.com/bug?extid=32de323b0addb9e114ff
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=16b17ebc580000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=144a8f70580000

#syz test

--- x/drivers/comedi/drivers/pcl812.c
+++ y/drivers/comedi/drivers/pcl812.c
@@ -1148,6 +1148,8 @@ static int pcl812_attach(struct comedi_d
 					 I8254_OSC_BASE_2MHZ, I8254_IO8, 0);
 		if (IS_ERR(dev->pacer))
 			return PTR_ERR(dev->pacer);
+		if (it->options[1] < 0 || it->options[1] > 31)
+			return -EINVAL;
 
 		if ((1 << it->options[1]) & board->irq_bits) {
 			ret = request_irq(it->options[1], pcl812_interrupt, 0,
--

  reply	other threads:[~2025-07-04 23:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04 21:50 syzbot
2025-07-04 23:45 ` Hillf Danton [this message]
2025-07-05  0:16   ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250704234551.2525-1-hdanton@sina.com \
    --to=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+32de323b0addb9e114ff@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®