mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+fce5d9d5bd067d6fbe9b@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [kernel?] general protection fault in pcl818_ai_cancel
Date: Sat,  5 Jul 2025 20:38:41 +0800	[thread overview]
Message-ID: <20250705123842.2616-1-hdanton@sina.com> (raw)
In-Reply-To: <68690156.a00a0220.c7b3.0036.GAE@google.com>

> Date: Sat, 05 Jul 2025 03:41:26 -0700
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    26ffb3d6f02c Add linux-next specific files for 20250704
> git tree:       linux-next
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=1304cf70580000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=8c567bd5a036e49d
> dashboard link: https://syzkaller.appspot.com/bug?extid=fce5d9d5bd067d6fbe9b
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=11022c8c580000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1704cf70580000

#syz test

--- x/drivers/comedi/drivers/pcl818.c
+++ y/drivers/comedi/drivers/pcl818.c
@@ -759,12 +759,15 @@ static int pcl818_ai_cancel(struct comed
 {
 	struct pcl818_private *devpriv = dev->private;
 	struct comedi_isadma *dma = devpriv->dma;
-	struct comedi_cmd *cmd = &s->async->cmd;
 
 	if (!devpriv->ai_cmd_running)
 		return 0;
 
 	if (dma) {
+		struct comedi_cmd *cmd;
+		if (!s || !s->async)
+			return 0;
+		cmd = &s->async->cmd;
 		if (cmd->stop_src == TRIG_NONE ||
 		    (cmd->stop_src == TRIG_COUNT &&
 		     s->async->scans_done < cmd->stop_arg)) {
--

  reply	other threads:[~2025-07-05 12:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-05 10:41 syzbot
2025-07-05 12:38 ` Hillf Danton [this message]
2025-07-05 14:06   ` syzbot
2025-10-23 13:46 ` Nikita Zhandarovich
2025-10-23 14:05   ` [syzbot] [comedi?] " syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250705123842.2616-1-hdanton@sina.com \
    --to=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+fce5d9d5bd067d6fbe9b@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®