mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+5cd373521edd68bebcb3@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [kernel?] UBSAN: shift-out-of-bounds in pcl726_attach
Date: Sat,  5 Jul 2025 20:47:11 +0800	[thread overview]
Message-ID: <20250705124712.2637-1-hdanton@sina.com> (raw)
In-Reply-To: <68690648.a00a0220.c7b3.0037.GAE@google.com>

> Date: Sat, 05 Jul 2025 04:02:32 -0700
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    c435a4f487e8 Merge tag 'riscv-for-linus-6.16-rc5' of git:/..
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=14ea4f70580000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=5ba6cef8f153bfeb
> dashboard link: https://syzkaller.appspot.com/bug?extid=5cd373521edd68bebcb3
> compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1116c582580000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12ea4f70580000

#syz test

--- x/drivers/comedi/drivers/pcl726.c
+++ y/drivers/comedi/drivers/pcl726.c
@@ -316,6 +316,8 @@ static int pcl726_attach(struct comedi_d
 	int ret;
 	int i;
 
+	if (it->options[1] < 0 || it->options[1] > 31)
+		return -EINVAL;
 	ret = comedi_request_region(dev, it->options[0], board->io_len);
 	if (ret)
 		return ret;
--

  reply	other threads:[~2025-07-05 12:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-05 11:02 syzbot
2025-07-05 12:47 ` Hillf Danton [this message]
2025-07-05 13:06   ` syzbot
2025-07-06  1:51 ` Edward Adam Davis
2025-07-06  2:10   ` syzbot
2025-07-06  2:10 ` [PATCH] commdi: pcl726: Prevent invalid irq number Edward Adam Davis
2025-07-07  9:47   ` Ian Abbott
2025-07-07 10:01     ` Ian Abbott
2025-07-07 11:43       ` [PATCH V2] " Edward Adam Davis
2025-07-07 12:23         ` Ian Abbott
2025-07-07 12:39           ` [PATCH V3] comedi: " Edward Adam Davis
2025-07-24 11:07             ` [PATCH V3 REPOST] " Ian Abbott
2025-07-24 11:11               ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250705124712.2637-1-hdanton@sina.com \
    --to=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+5cd373521edd68bebcb3@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®