mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Guillaume Ranquet" <granquet@baylibre.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7173: fix channels index for syscalib_mode
Date: Sun, 6 Jul 2025 11:35:25 +0100	[thread overview]
Message-ID: <20250706113525.3996d46b@jic23-huawei> (raw)
In-Reply-To: <20250703-iio-adc-ad7173-fix-channels-index-for-syscalib_mode-v1-1-7fdaedb9cac0@baylibre.com>

On Thu, 03 Jul 2025 14:51:17 -0500
David Lechner <dlechner@baylibre.com> wrote:

> Fix the index used to look up the channel when accessing the
> syscalib_mode attribute. The address field is a 0-based index (same
> as scan_index) that it used to access the channel in the
> ad7173_channels array throughout the driver. The channels field, on
> the other hand, may not match the address field depending on the
> channel configuration specified in the device tree and could result
> in an out-of-bounds access.
> 
> Fixes: 031bdc8aee01 ("iio: adc: ad7173: add calibration support")
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Applied and marked for stable.
> ---
>  drivers/iio/adc/ad7173.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index dd9fa35555c79ead5a1b88d1dc6cc3db122502be..03412895f6dc71fcf8a07d09eb9f94a3840f02ef 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -318,7 +318,7 @@ static int ad7173_set_syscalib_mode(struct iio_dev *indio_dev,
>  {
>  	struct ad7173_state *st = iio_priv(indio_dev);
>  
> -	st->channels[chan->channel].syscalib_mode = mode;
> +	st->channels[chan->address].syscalib_mode = mode;
>  
>  	return 0;
>  }
> @@ -328,7 +328,7 @@ static int ad7173_get_syscalib_mode(struct iio_dev *indio_dev,
>  {
>  	struct ad7173_state *st = iio_priv(indio_dev);
>  
> -	return st->channels[chan->channel].syscalib_mode;
> +	return st->channels[chan->address].syscalib_mode;
>  }
>  
>  static ssize_t ad7173_write_syscalib(struct iio_dev *indio_dev,
> @@ -347,7 +347,7 @@ static ssize_t ad7173_write_syscalib(struct iio_dev *indio_dev,
>  	if (!iio_device_claim_direct(indio_dev))
>  		return -EBUSY;
>  
> -	mode = st->channels[chan->channel].syscalib_mode;
> +	mode = st->channels[chan->address].syscalib_mode;
>  	if (sys_calib) {
>  		if (mode == AD7173_SYSCALIB_ZERO_SCALE)
>  			ret = ad_sd_calibrate(&st->sd, AD7173_MODE_CAL_SYS_ZERO,
> 
> ---
> base-commit: 6742eff60460e77158d4f1b233f17e0345c9e66a
> change-id: 20250703-iio-adc-ad7173-fix-channels-index-for-syscalib_mode-49b404e99e0c
> 
> Best regards,


      reply	other threads:[~2025-07-06 10:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03 19:51 David Lechner
2025-07-06 10:35 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250706113525.3996d46b@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=granquet@baylibre.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®