Re: [GIT PULL] Crypto library fixes for v6.16-rc3

[Eric Biggers <ebiggers@kernel.org>]

On Wed, Jun 18, 2025 at 06:05:37PM -0400, Kent Overstreet wrote:
> On Wed, Jun 18, 2025 at 09:59:18PM +0000, Eric Biggers wrote:
> > On Wed, Jun 18, 2025 at 05:40:27PM -0400, Kent Overstreet wrote:
> > > On Wed, Jun 18, 2025 at 12:49:58PM -0700, Eric Biggers wrote:
> > > > The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494:
> > > > 
> > > >   Linux 6.16-rc1 (2025-06-08 13:44:43 -0700)
> > > > 
> > > > are available in the Git repository at:
> > > > 
> > > >   https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git tags/libcrypto-for-linus
> > > > 
> > > > for you to fetch changes up to 9d4204a8106fe7dc80e3f2e440c8f2ba1ba47319:
> > > > 
> > > >   lib/crypto/poly1305: Fix arm64's poly1305_blocks_arch() (2025-06-16 12:51:34 -0700)
> > > > 
> > > > ----------------------------------------------------------------
> > > > 
> > > > - Fix a regression in the arm64 Poly1305 code
> > > 
> > > Some more tests too, perhaps? :)
> > > 
> > > This was a bit of a scary one, since poly1305 was returning an
> > > inconsistent result, not total garbage. Meaning most of the tests
> > > passed, but fortunately the migrate tests read data written by userspace
> > > with a different library.
> > 
> > Yep, I have a KUnit test for Poly1305 planned.  Actually, I already wrote a
> > preliminary one and used it to test this patch.  I just haven't sent it out for
> > review quite yet, since so far it's just a one-off test that isn't too complete,
> > and I'm not satisfied with it quite yet.  I'd like to reuse the
> > hash-test-template.h I'm adding for SHA-2
> > (https://lore.kernel.org/linux-crypto/20250616014019.415791-5-ebiggers@kernel.org/)
> > which would result in a more complete test.  I'd also like to include tests for
> > some of the overflow cases that are specific to Poly1305.
> > 
> > So we're kind of still in an early stage where we're defining what the KUnit
> > testing for lib/crypto/ is going to look like.  I am working on it, though!
> 
> I do a little dance any time someeone says something like that about
> testing. Bravo :)
> 
> (And now, back to sifting through the rest of the rc1 breakage.)

FYI, the following patch adds a KUnit test suite for Poly1305:
https://lore.kernel.org/linux-crypto/20250706232817.179500-5-ebiggers@kernel.org/

- Eric