From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: arm: qcom: Split HP Omnibook X14 AI in SoC variants
Date: Tue, 8 Jul 2025 09:45:18 +0200 [thread overview]
Message-ID: <20250708-brawny-optimal-lynx-8aab31@krzk-bin> (raw)
In-Reply-To: <20250705-hp-x14-x1p-v4-1-1c351dbeaf18@oldschoolsolutions.biz>
On Sat, Jul 05, 2025 at 10:31:54PM +0200, Jens Glathe wrote:
> The HP Omnibook X14 AI PC is available in fe0 (Hamoa, x1e80100) and
> fe1 (Purwa, x1p42100) SKUs. Since they are not completely dtb-compatible,
> split the model strings in 2 variants:
>
> hp,omnibook-x14 compatible to qcom,x1e80100
> hp,omnibook-x14-fe1 compatible to cqom,x1p42100
I don't see split here. You are adding a new compatible for the fe1
variant. It's fine to mention there is fe0 already, but main point of
commit msg should express what you want to do and doing here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-08 7:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-05 20:31 [PATCH v4 0/3] arm64: dts: qcom: x1-hp-x14: Add support for X1P42100 HP Omnibook X14 Jens Glathe via B4 Relay
2025-07-05 20:31 ` [PATCH v4 1/3] dt-bindings: arm: qcom: Split HP Omnibook X14 AI in SoC variants Jens Glathe via B4 Relay
2025-07-08 7:45 ` Krzysztof Kozlowski [this message]
2025-07-08 8:17 ` Jens Glathe
2025-07-08 10:26 ` Krzysztof Kozlowski
2025-07-05 20:31 ` [PATCH v4 2/3] arm64: dts: qcom: x1-hp-x14: Commonalize HP Omnibook X14 device tree Jens Glathe via B4 Relay
2025-07-08 14:17 ` Konrad Dybcio
2025-07-08 14:26 ` Jens Glathe
2025-07-05 20:31 ` [PATCH v4 3/3] arm64: dts: qcom: x1-hp-x14: Add support for X1P42100 HP Omnibook X14 Jens Glathe via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708-brawny-optimal-lynx-8aab31@krzk-bin \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jens.glathe@oldschoolsolutions.biz \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®