mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Luca Weiss <luca.weiss@fairphone.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	 Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Abel Vesa <abel.vesa@linaro.org>,
	~postmarketos/upstreaming@lists.sr.ht,
	 phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: phy: qcom,snps-eusb2-repeater: Document qcom,tune-res-fsdif
Date: Tue, 8 Jul 2025 10:21:57 +0200	[thread overview]
Message-ID: <20250708-stoic-slim-bison-ac55ee@krzk-bin> (raw)
In-Reply-To: <20250708-unicorn-of-ancient-excellence-e8945c@krzk-bin>

On Tue, Jul 08, 2025 at 10:13:24AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Jun 25, 2025 at 11:14:56AM +0200, Luca Weiss wrote:
> > Document the FS Differential TX Output Resistance Tuning value found on
> > the eUSB2 repeater on Qualcomm PMICs.
> > 
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > ---
> >  Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > index 27f064a71c9fb8cb60e8333fb285f0510a4af94f..6bfd11657e2992735998063b3ca390e04a03930d 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > @@ -52,6 +52,12 @@ properties:
> >      minimum: 0
> >      maximum: 7
> >  
> > +  qcom,tune-res-fsdif:
> > +    $ref: /schemas/types.yaml#/definitions/uint8
> > +    description: FS Differential TX Output Resistance Tuning
> 
> Resistance is in Ohms, tuning could be in dB, so I wonder what are the
> actual units here. Neither commit msg nor this description helps me to
> understand that.

I checked and the values are in Ohms.

Best regards,
Krzysztof


  reply	other threads:[~2025-07-08  8:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25  9:14 [PATCH 0/4] Add support for eUSB2 repeater on PMIV0104 Luca Weiss
2025-06-25  9:14 ` [PATCH 1/4] dt-bindings: phy: qcom,snps-eusb2-repeater: Document qcom,tune-res-fsdif Luca Weiss
2025-07-08  8:13   ` Krzysztof Kozlowski
2025-07-08  8:21     ` Krzysztof Kozlowski [this message]
2025-07-08  8:31       ` Luca Weiss
2025-07-09  9:40         ` Luca Weiss
2025-07-09 10:16           ` Krzysztof Kozlowski
2025-07-09 12:22             ` Luca Weiss
2025-07-09 13:51               ` Krzysztof Kozlowski
2025-06-25  9:14 ` [PATCH 2/4] phy: qualcomm: phy-qcom-eusb2-repeater: Support tune-res-fsdif prop Luca Weiss
2025-06-25 10:08   ` neil.armstrong
2025-06-25 11:40   ` Abel Vesa
2025-06-25  9:14 ` [PATCH 3/4] dt-bindings: phy: qcom,snps-eusb2-repeater: Add compatible for PMIV0104 Luca Weiss
2025-07-08  8:21   ` Krzysztof Kozlowski
2025-06-25  9:14 ` [PATCH 4/4] phy: qualcomm: phy-qcom-eusb2-repeater: Add support " Luca Weiss
2025-06-25 10:09   ` neil.armstrong
2025-06-25 11:40   ` Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250708-stoic-slim-bison-ac55ee@krzk-bin \
    --to=krzk@kernel.org \
    --cc=abel.vesa@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=luca.weiss@fairphone.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®