From: Hillf Danton <hdanton@sina.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Bart Van Assche <bvanassche@acm.org>,
axboe@kernel.dk, josef@toxicpanda.com,
linux-block@vger.kernel.org,
syzbot <syzbot+3dbc6142c85cc77eaf04@syzkaller.appspotmail.com>,
Ming Lei <ming.lei@redhat.com>,
linux-kernel@vger.kernel.org, nbd@other.debian.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [nbd?] possible deadlock in nbd_queue_rq
Date: Tue, 8 Jul 2025 09:24:49 +0800 [thread overview]
Message-ID: <20250708012450.2858-1-hdanton@sina.com> (raw)
In-Reply-To: <b8769d22-fa19-4374-bbcc-be3f06f420bf@I-love.SAKURA.ne.jp>
On Tue, 8 Jul 2025 09:52:18 +0900 Tetsuo Handa wrote:
> On 2025/07/08 9:18, Hillf Danton wrote:
> > On Mon, 7 Jul 2025 10:39:44 -0700 Bart Van Assche wrote:
> >> On 7/6/25 5:59 PM, Hillf Danton wrote:
> >>> and given the second one, the report is false positive.
> >>
> >> Whether or not this report is a false positive, the root cause should be
> >> fixed because lockdep disables itself after the first circular locking
> >> complaint. From print_usage_bug() in kernel/locking/lockdep.c:
> >>
> >> if (!debug_locks_off() || debug_locks_silent)
> >> return;
> >>
> > The root cause could be walked around for example by trying not to init
> > nbd more than once.
>
> How did you come to think so?
>
Based on that nbd_init appears twice in the lock chain syzbot reported.
> nbd_init() is already called only once because of module_init(nbd_init).
>
Ok Bart is misguiding.
next prev parent reply other threads:[~2025-07-08 1:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 16:33 syzbot
2025-07-07 0:59 ` Hillf Danton
2025-07-07 17:39 ` Bart Van Assche
2025-07-08 0:18 ` Hillf Danton
2025-07-08 0:52 ` Tetsuo Handa
2025-07-08 1:24 ` Hillf Danton [this message]
2025-07-08 2:19 ` Tetsuo Handa
2025-07-08 16:23 ` Bart Van Assche
2025-09-15 2:16 ` syzbot
2025-09-16 18:18 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708012450.2858-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nbd@other.debian.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=syzbot+3dbc6142c85cc77eaf04@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®