From: "Theodore Ts'o" <tytso@mit.edu>
To: I Hsin Cheng <richard120310@gmail.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] ext4: Refactor breaking condition for xattr_find_entry()
Date: Mon, 7 Jul 2025 22:24:53 -0400 [thread overview]
Message-ID: <20250708022453.GB1845251@mit.edu> (raw)
In-Reply-To: <20250708020013.175728-1-richard120310@gmail.com>
On Tue, Jul 08, 2025 at 10:00:13AM +0800, I Hsin Cheng wrote:
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index 8d15acbacc20..1993622e3c74 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -338,7 +338,7 @@ xattr_find_entry(struct inode *inode, struct ext4_xattr_entry **pentry,
> cmp = name_len - entry->e_name_len;
> if (!cmp)
> cmp = memcmp(name, entry->e_name, name_len);
> - if (cmp <= 0 && (sorted || cmp == 0))
> + if (!cmp || (cmp < 0 && sorted))
This is *not* identical. Suppose memcmp returns a positive value
(say, 1). Previously, the conditional would be false. With your
change, !cmp would be true, so the overall conditional would be true.
So this does not appear to be a valid transformation.
(Note that valid transformations will be done by the compiler
automatically, without needing to make code changes.)
- Ted
next prev parent reply other threads:[~2025-07-08 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 2:00 I Hsin Cheng
2025-07-08 2:24 ` Theodore Ts'o [this message]
2025-07-08 3:01 ` I Hsin Cheng
2025-07-19 21:45 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708022453.GB1845251@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard120310@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®