From: Alistair Popple <apopple@nvidia.com>
To: rust-for-linux@vger.kernel.org
Cc: "Alistair Popple" <apopple@nvidia.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"John Hubbard" <jhubbard@nvidia.com>,
"Alexandre Courbot" <acourbot@nvidia.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] rust: Add dma_set_mask() and dma_set_coherent_mask() bindings
Date: Tue, 8 Jul 2025 16:04:50 +1000 [thread overview]
Message-ID: <20250708060451.398323-1-apopple@nvidia.com> (raw)
Add bindings to allow setting the DMA masks for both a generic device
and a PCI device.
Signed-off-by: Alistair Popple <apopple@nvidia.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Alex Gaynor <alex.gaynor@gmail.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Gary Guo <gary@garyguo.net>
Cc: "Björn Roy Baron" <bjorn3_gh@protonmail.com>
Cc: Benno Lossin <lossin@kernel.org>
Cc: Andreas Hindborg <a.hindborg@kernel.org>
Cc: Alice Ryhl <aliceryhl@google.com>
Cc: Trevor Gross <tmgross@umich.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Alexandre Courbot <acourbot@nvidia.com>
Cc: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
rust/kernel/device.rs | 25 +++++++++++++++++++++++++
rust/kernel/pci.rs | 23 +++++++++++++++++++++++
2 files changed, 48 insertions(+)
diff --git a/rust/kernel/device.rs b/rust/kernel/device.rs
index dea06b79ecb5..77a1293a1c82 100644
--- a/rust/kernel/device.rs
+++ b/rust/kernel/device.rs
@@ -10,6 +10,7 @@
types::{ARef, Opaque},
};
use core::{fmt, marker::PhantomData, ptr};
+use kernel::prelude::*;
#[cfg(CONFIG_PRINTK)]
use crate::c_str;
@@ -67,6 +68,30 @@ pub(crate) fn as_raw(&self) -> *mut bindings::device {
self.0.get()
}
+ /// Sets the DMA mask for the device.
+ pub fn dma_set_mask(&self, mask: u64) -> Result {
+ // SAFETY: By the type invariant of `device::Device`, `self.as_ref().as_raw()` is valid.
+ let ret = unsafe { bindings::dma_set_mask(&(*self.as_raw()) as *const _ as *mut _, mask) };
+ if ret != 0 {
+ Err(Error::from_errno(ret))
+ } else {
+ Ok(())
+ }
+ }
+
+ /// Sets the coherent DMA mask for the device.
+ pub fn dma_set_coherent_mask(&self, mask: u64) -> Result {
+ // SAFETY: By the type invariant of `device::Device`, `self.as_ref().as_raw()` is valid.
+ let ret = unsafe {
+ bindings::dma_set_coherent_mask(&(*self.as_raw()) as *const _ as *mut _, mask)
+ };
+ if ret != 0 {
+ Err(Error::from_errno(ret))
+ } else {
+ Ok(())
+ }
+ }
+
/// Returns a reference to the parent device, if any.
#[cfg_attr(not(CONFIG_AUXILIARY_BUS), expect(dead_code))]
pub(crate) fn parent(&self) -> Option<&Self> {
diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
index 8435f8132e38..7f640ba8f19c 100644
--- a/rust/kernel/pci.rs
+++ b/rust/kernel/pci.rs
@@ -369,6 +369,17 @@ fn as_raw(&self) -> *mut bindings::pci_dev {
}
}
+impl<'a, Ctx: device::DeviceContext> From<&'a kernel::pci::Device<Ctx>>
+ for &'a device::Device<Ctx>
+{
+ fn from(pdev: &kernel::pci::Device<Ctx>) -> &device::Device<Ctx> {
+ // SAFETY: The returned reference has the same lifetime as the
+ // pci::Device which holds a reference on the underlying device
+ // pointer.
+ unsafe { device::Device::as_ref(&(*pdev.as_raw()).dev as *const _ as *mut _) }
+ }
+}
+
impl Device {
/// Returns the PCI vendor ID.
pub fn vendor_id(&self) -> u16 {
@@ -393,6 +404,18 @@ pub fn resource_len(&self, bar: u32) -> Result<bindings::resource_size_t> {
// - by its type invariant `self.as_raw` is always a valid pointer to a `struct pci_dev`.
Ok(unsafe { bindings::pci_resource_len(self.as_raw(), bar.try_into()?) })
}
+
+ /// Set the DMA mask for PCI device.
+ pub fn dma_set_mask(&self, mask: u64) -> Result {
+ let dev: &device::Device = self.into();
+ dev.dma_set_mask(mask)
+ }
+
+ /// Set the coherent DMA mask for the PCI device.
+ pub fn dma_set_coherent_mask(&self, mask: u64) -> Result {
+ let dev: &device::Device = self.into();
+ dev.dma_set_coherent_mask(mask)
+ }
}
impl Device<device::Bound> {
--
2.47.2
next reply other threads:[~2025-07-08 6:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 6:04 Alistair Popple [this message]
2025-07-08 6:04 ` [PATCH 2/2] rust: Add several miscellaneous PCI helpers Alistair Popple
2025-07-08 7:05 ` Alexandre Courbot
2025-07-08 8:07 ` Greg Kroah-Hartman
2025-07-09 1:50 ` Alistair Popple
2025-07-08 9:32 ` Danilo Krummrich
2025-07-09 1:43 ` Alistair Popple
2025-07-08 7:01 ` [PATCH 1/2] rust: Add dma_set_mask() and dma_set_coherent_mask() bindings Alexandre Courbot
2025-07-08 8:07 ` Alistair Popple
2025-07-08 8:40 ` Danilo Krummrich
2025-07-08 9:48 ` Danilo Krummrich
2025-07-08 20:44 ` Danilo Krummrich
2025-07-09 1:41 ` Alistair Popple
2025-07-10 19:39 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708060451.398323-1-apopple@nvidia.com \
--to=apopple@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jhubbard@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®