From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3E19EEC3 for ; Tue, 8 Jul 2025 14:06:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751983593; cv=none; b=rm+ppo55sP0pAjmHxTplBlgM2GkMKDfjr+0QrsobXfuZ7JCrZW6xuD84Vt0RsWQ6g+lRPt3Fh9XGs3cmH0nwGI5atU/Am9cU15oEtndjjgfI9bPJdgI6vJwobypTpZ3umlgHXLCmPsOZk9C/GAxNDK+UVIJx1L5Y4WQR69jp41w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751983593; c=relaxed/simple; bh=BINVLnRgyb20mtAp5cKy1Cm5MJUnIiU9I4ytjoEXwOw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jPgTg5bi6kIWB7deZBSN3/VZAoVbbZYkb2fXwJ/OETRzN4xmricToIyLsSA6hWguKHnOIuPiu0uf5SX2nBMRIkpShm4xafSVtya6rJX33qhgLy3diGL5lTvmxhgR3bGIF8l0PuGNvxZAJJRPfZwwdTP3FRg6ahLVkkkAE/QySk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=ob5JnNmL; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="ob5JnNmL" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7da363af61cso72119485a.0 for ; Tue, 08 Jul 2025 07:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1751983591; x=1752588391; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Zi7H4e9g21Nfu25Zqs4l/n2K5Xp4dE24U9jx1txkOqM=; b=ob5JnNmL1bALluVuIazMQe61MO0lKCK0TSrKq/hifvHdCUnk0bBVkAsSlcFA8h7Vss 8cp5RK1FKBxIDpvbxIBcsdeq5c3lXWCcvmzcY0imUtSWWSu+WGCeDD8YfKIT5+K8l2uX DXi5s3mCkbUzZa4kcT5sZjIR0tPKloF9KMe7VaDk7dP2fZlqhAeytpF87RN6P+N52Uj5 OgEXcm7pecPzj3OqXHRgRpGmPWfrTVL5OblT7ngJBNNvx07zRnZ80LP5Nm5mxVZlKFeU Bn7EkX7MM8Ui3aNE/qJUNknNNXoWW3py+217mtH/2tdEk4JY+ORuc5VHpiN2jalPexmO +MHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751983591; x=1752588391; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Zi7H4e9g21Nfu25Zqs4l/n2K5Xp4dE24U9jx1txkOqM=; b=jvrWoMZcNVOEmmWx5vsET0Aj9mAU3dc/K7qK+kyYvqyz305+3ITSqT9Ffbx1YEIZnO sh7y3MYBU9OFgPrCPbo8RRiSQ9/0kqhNX9myHvvyU8cy9cA+iVgsjfKX2cLxVkxvNmjK w+zUs6hA/s3sHQ/fige641sVvgfJCel9et5sL7HZqulFQ5xgbZOOCOcivofNPhTMfD// xaTLZYGqJyXlzBY6oEG8ataXmGWZNhe7SQtdFZyJQ2CdHcRmjYBNyF4xbhscKFDhR0dc 1eJ/C2i+auTYjTBjyjP/8noqmW0Twec5YRnTnLFPKHjSUuJQgrnlFcqDuJMUSnd9pVVx riPg== X-Forwarded-Encrypted: i=1; AJvYcCUP94hDbWv/JrBV3C0lUf7S3HO+uuZN0ctzyXJEKLT6pyCts6CYMxWK34/gibEHdA2bKqahz4/doaIOroo=@vger.kernel.org X-Gm-Message-State: AOJu0YzUVzQUgrSsjeJ4iaRXYuP968vcvKNpODUrrk90xOuC7jNQUeBO Ju4wMORsqnF/6w7hEMhFzSvEmCNHZp9fY29vKJ9SdI1yqa+erMek6r40g/rqZWv9KaE= X-Gm-Gg: ASbGncvt6OzkIxBs2n+2mxG6Cy8RDCEUdccMt7rCzBf+YwX4e9WMqXIk+Sh0BFciQTe czn8Ld7HcC7Gp1NBa8uSBzoQRn54RrxlSgc2xd3+7dcloJyLcX+caijcJW1jYDxXJOWNco7liRe s2xHEq+JNN7djnbeFApXa07gDEYGxVyXzXH8tSq2cijFN89NOWOdCw4AbE2rlsUP+4MEi1Xczks WZWJy/Pe93QrGbZzD/8okPxTAUgBcPMqzb178AD3HLTabY7AfT77wXy8aBS1R7qu0eE4VzBrTYK jkGksw/qphZ1JjGfBJqmn7/uVLYtwKH4OPwR8fIZlt6kBiRMIVzBrVXQZVS0c6K6RxaJCMVeAeR omeYCgw8We5XlAOndiVOzh/0Nu5uxCAj2fOnpWA== X-Google-Smtp-Source: AGHT+IE/cztazeqpYwjRDoFWW5gJZRO8uoDuF7N/tMta0ZaCg/Nk+lDvQEF/OVmMyutYglTV2SlC/w== X-Received: by 2002:a05:620a:8009:b0:7d0:97b1:bfa with SMTP id af79cd13be357-7da01a8a1e3mr539517585a.8.1751983590756; Tue, 08 Jul 2025 07:06:30 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d5dbeb67f2sm781455285a.111.2025.07.08.07.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 07:06:30 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uZ8xp-00000006iCd-3LhG; Tue, 08 Jul 2025 11:06:29 -0300 Date: Tue, 8 Jul 2025 11:06:29 -0300 From: Jason Gunthorpe To: Baolu Lu Cc: Joerg Roedel , Will Deacon , Robin Murphy , Kevin Tian , Jann Horn , Vasant Hegde , Dave Hansen , Alistair Popple , Peter Zijlstra , Uladzislau Rezki , Jean-Philippe Brucker , Andy Lutomirski , Yi Lai , iommu@lists.linux.dev, security@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/1] iommu/sva: Invalidate KVA range on kernel TLB flush Message-ID: <20250708140629.GQ904431@ziepe.ca> References: <20250704133056.4023816-1-baolu.lu@linux.intel.com> <0c6f6b3e-d68d-4deb-963e-6074944afff7@linux.intel.com> <20250708122755.GV1410929@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250708122755.GV1410929@nvidia.com> On Tue, Jul 08, 2025 at 09:27:55AM -0300, Jason Gunthorpe wrote: > On Tue, Jul 08, 2025 at 01:42:53PM +0800, Baolu Lu wrote: > > > +void iommu_sva_invalidate_kva_range(unsigned long start, unsigned long end) > > > +{ > > > + struct iommu_mm_data *iommu_mm; > > > + > > > + might_sleep(); > > > > Yi Lai reported an issue here. This interface could > > potentially be called in a non-sleepable context. > > Oh thats really bad, the notifiers inside the iommu driver are not > required to be called in a sleepable context either and I don't really > want to change that requirement. Actually, I have got confused here with the hmm use of notifiers. The iommu drivers use arch_invalidate_secondary_tlbs so they are already in atomic contexts. So your idea to use a spinlock seems correct. Jason