From: Rob Herring <robh@kernel.org>
To: Paresh Bhagat <p-bhagat@ti.com>
Cc: nm@ti.com, vigneshr@ti.com, praneeth@ti.com, kristo@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, khasim@ti.com, v-singh1@ti.com,
afd@ti.com, bb@ti.com, devarsht@ti.com, s-vadapalli@ti.com,
andrew@lunn.ch
Subject: Re: [PATCH v7 3/4] arm64: dts: ti: Add pinctrl entries for AM62D2 family of SoCs
Date: Tue, 8 Jul 2025 15:22:59 -0500 [thread overview]
Message-ID: <20250708202259.GA904737-robh@kernel.org> (raw)
In-Reply-To: <20250708085839.1498505-4-p-bhagat@ti.com>
On Tue, Jul 08, 2025 at 02:28:38PM +0530, Paresh Bhagat wrote:
> Update k3-pinctrl file to include pin definitions for AM62D2 family of
> SoCs.
>
> Signed-off-by: Paresh Bhagat <p-bhagat@ti.com>
> Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-pinctrl.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-pinctrl.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> index cac7cccc1112..0cf57179c974 100644
> --- a/arch/arm64/boot/dts/ti/k3-pinctrl.h
> +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> @@ -63,6 +63,9 @@
> #define AM62AX_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode))
> #define AM62AX_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode))
>
> +#define AM62DX_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode))
> +#define AM62DX_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode))
> +
> #define AM62PX_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode))
> #define AM62PX_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode))
Why is the same expression just repeated over and over? Looks like this
needs some refactoring.
next prev parent reply other threads:[~2025-07-08 20:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 8:58 [PATCH v7 0/4] Add support for AM62D2 SoC and EVM Paresh Bhagat
2025-07-08 8:58 ` [PATCH v7 1/4] arm64: dts: ti: Add bootph property to nodes at source for am62a Paresh Bhagat
2025-07-08 8:58 ` [PATCH v7 2/4] dt-bindings: arm: ti: Add AM62D2 SoC and Boards Paresh Bhagat
2025-07-08 8:58 ` [PATCH v7 3/4] arm64: dts: ti: Add pinctrl entries for AM62D2 family of SoCs Paresh Bhagat
2025-07-08 20:22 ` Rob Herring [this message]
2025-07-09 5:51 ` Vignesh Raghavendra
2025-07-08 8:58 ` [PATCH v7 4/4] arm64: dts: ti: Add support for AM62D2-EVM Paresh Bhagat
2025-07-15 5:27 ` [PATCH v7 0/4] Add support for AM62D2 SoC and EVM Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708202259.GA904737-robh@kernel.org \
--to=robh@kernel.org \
--cc=afd@ti.com \
--cc=andrew@lunn.ch \
--cc=bb@ti.com \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=khasim@ti.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=p-bhagat@ti.com \
--cc=praneeth@ti.com \
--cc=s-vadapalli@ti.com \
--cc=v-singh1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®