mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xu Yilun <yilun.xu@linux.intel.com>
To: jgg@nvidia.com, jgg@ziepe.ca, kevin.tian@intel.com,
	will@kernel.org, aneesh.kumar@kernel.org
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
	joro@8bytes.org, robin.murphy@arm.com, shuah@kernel.org,
	nicolinc@nvidia.com, aik@amd.com, dan.j.williams@intel.com,
	baolu.lu@linux.intel.com, yilun.xu@intel.com
Subject: [PATCH v4 7/7] iommufd/selftest: Add coverage for vdevice tombstone
Date: Wed,  9 Jul 2025 12:02:34 +0800	[thread overview]
Message-ID: <20250709040234.1773573-8-yilun.xu@linux.intel.com> (raw)
In-Reply-To: <20250709040234.1773573-1-yilun.xu@linux.intel.com>

This tests the flow to tombstone vdevice when idevice is to be unbound
before vdevice destruction. The expected result is:

 - idevice unbinding tombstones vdevice ID, the ID can't be repurposed
   anymore.
 - Even ioctl(IOMMU_DESTROY) can't free the tombstoned ID.
 - iommufd_fops_release() can still free everything.

Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
---
 tools/testing/selftests/iommu/iommufd.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selftests/iommu/iommufd.c
index 4a9b6e3b37fa..e1470a7a42cd 100644
--- a/tools/testing/selftests/iommu/iommufd.c
+++ b/tools/testing/selftests/iommu/iommufd.c
@@ -3016,6 +3016,20 @@ TEST_F(iommufd_viommu, vdevice_cache)
 	test_ioctl_destroy(vdev_id);
 }
 
+TEST_F(iommufd_viommu, vdevice_tombstone)
+{
+	uint32_t viommu_id = self->viommu_id;
+	uint32_t dev_id = self->device_id;
+	uint32_t vdev_id = 0;
+
+	if (!dev_id)
+		SKIP(return, "Skipping test for variant no_viommu");
+
+	test_cmd_vdevice_alloc(viommu_id, dev_id, 0x99, &vdev_id);
+	test_ioctl_destroy(self->stdev_id);
+	EXPECT_ERRNO(ENOENT, _test_ioctl_destroy(self->fd, vdev_id));
+}
+
 FIXTURE(iommufd_device_pasid)
 {
 	int fd;
-- 
2.25.1


  parent reply	other threads:[~2025-07-09  4:11 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09  4:02 [PATCH v4 0/7] iommufd: Destroy vdevice on device unbind Xu Yilun
2025-07-09  4:02 ` [PATCH v4 1/7] iommufd/viommu: Roll back to use iommufd_object_alloc() for vdevice Xu Yilun
2025-07-10  7:32   ` Tian, Kevin
2025-07-10 18:26   ` Nicolin Chen
2025-07-11 17:42   ` Jason Gunthorpe
2025-07-09  4:02 ` [PATCH v4 2/7] iommufd: Add iommufd_object_tombstone_user() helper Xu Yilun
2025-07-10  7:35   ` Tian, Kevin
2025-07-10 19:08   ` Nicolin Chen
2025-07-11 15:02     ` Xu Yilun
2025-07-11 19:39       ` Nicolin Chen
2025-07-11 21:33       ` Jason Gunthorpe
2025-07-11 22:04         ` Nicolin Chen
2025-07-11 17:44   ` Jason Gunthorpe
2025-07-09  4:02 ` [PATCH v4 3/7] iommufd: Add a pre_destroy() op for objects Xu Yilun
2025-07-10  7:40   ` Tian, Kevin
2025-07-10 17:15     ` Jason Gunthorpe
2025-07-11  3:16       ` Tian, Kevin
2025-07-11  9:38         ` Xu Yilun
2025-07-11 22:09   ` Nicolin Chen
2025-07-09  4:02 ` [PATCH v4 4/7] iommufd: Destroy vdevice on idevice destroy Xu Yilun
2025-07-10  8:03   ` Tian, Kevin
2025-07-12  2:22   ` Nicolin Chen
2025-07-12 17:47     ` Xu Yilun
2025-07-14 16:40       ` Xu Yilun
2025-07-14 16:53         ` Jason Gunthorpe
2025-07-14 17:34           ` Nicolin Chen
2025-07-14 18:03             ` Xu Yilun
2025-07-12  2:26   ` Nicolin Chen
2025-07-09  4:02 ` [PATCH v4 5/7] iommufd/vdevice: Remove struct device reference from struct vdevice Xu Yilun
2025-07-10  8:04   ` Tian, Kevin
2025-07-12  2:27   ` Nicolin Chen
2025-07-09  4:02 ` [PATCH v4 6/7] iommufd/selftest: Explicitly skip tests for inapplicable variant Xu Yilun
2025-07-10  8:06   ` Tian, Kevin
2025-07-12  2:39   ` Nicolin Chen
2025-07-09  4:02 ` Xu Yilun [this message]
2025-07-10  8:10   ` [PATCH v4 7/7] iommufd/selftest: Add coverage for vdevice tombstone Tian, Kevin
2025-07-10  9:25     ` Xu Yilun
2025-07-11  3:12       ` Tian, Kevin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250709040234.1773573-8-yilun.xu@linux.intel.com \
    --to=yilun.xu@linux.intel.com \
    --cc=aik@amd.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@nvidia.com \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolinc@nvidia.com \
    --cc=robin.murphy@arm.com \
    --cc=shuah@kernel.org \
    --cc=will@kernel.org \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®