From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Gabriele Paoloni <gpaoloni@redhat.com>,
mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [RFC PATCH RESEND] tracing: add kernel documentation for trace_array_set_clr_event, trace_set_clr_event and supporting functions
Date: Wed, 9 Jul 2025 10:06:26 +0900 [thread overview]
Message-ID: <20250709100626.fc0611eb6801b7a8dad9164f@kernel.org> (raw)
In-Reply-To: <20250701195939.3e297e20@gandalf.local.home>
On Tue, 1 Jul 2025 19:59:39 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> > + * __ftrace_event_enable_disable - enable or disable a trace event
> > + * @file: trace event file associated with the event.
> > + * @enable: 0 or 1 respectively to disable/enable the event (any other value is
> > + * invalid).
>
> Saying 0 or 1 should assume that those are the only values. Don't need the
> content in the parenthesis.
BTW, it should be "0 or !0"? (or we should make it boolean)
This description means if it is "2", that is undefined.
Thanks,
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2025-07-09 1:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 8:56 Gabriele Paoloni
2025-07-01 23:59 ` Steven Rostedt
2025-07-02 13:45 ` Gabriele Paoloni
2025-07-02 14:40 ` Steven Rostedt
2025-07-02 15:19 ` Steven Rostedt
2025-07-02 17:16 ` Gabriele Paoloni
2025-07-08 22:12 ` Steven Rostedt
2025-07-02 16:38 ` Gabriele Paoloni
2025-07-09 1:06 ` Masami Hiramatsu [this message]
2025-07-09 1:25 ` Steven Rostedt
2025-07-09 13:35 ` Gabriele Paoloni
2025-07-09 14:12 ` Steven Rostedt
2025-07-09 14:49 ` Gabriele Paoloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709100626.fc0611eb6801b7a8dad9164f@kernel.org \
--to=mhiramat@kernel.org \
--cc=gpaoloni@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®