From: Christian Brauner <brauner@kernel.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: Christian Brauner <brauner@kernel.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] uapi: export PROCFS_ROOT_INO
Date: Thu, 10 Jul 2025 09:39:29 +0200 [thread overview]
Message-ID: <20250710-visuell-joghurt-c76814720040@brauner> (raw)
In-Reply-To: <20250708-uapi-procfs-root-ino-v1-1-6ae61e97c79b@cyphar.com>
On Tue, 08 Jul 2025 23:21:51 +1000, Aleksa Sarai wrote:
> The root inode of /proc having a fixed inode number has been part of the
> core kernel ABI since its inception, and recently some userspace
> programs (mainly container runtimes) have started to explicitly depend
> on this behaviour.
>
> The main reason this is useful to userspace is that by checking that a
> suspect /proc handle has fstype PROC_SUPER_MAGIC and is PROCFS_ROOT_INO,
> they can then use openat2(RESOLVE_{NO_{XDEV,MAGICLINK},BENEATH}) to
> ensure that there isn't a bind-mount that replaces some procfs file with
> a different one. This kind of attack has lead to security issues in
> container runtimes in the past (such as CVE-2019-19921) and libraries
> like libpathrs[1] use this feature of procfs to provide safe procfs
> handling functions.
>
> [...]
Applied to the vfs-6.17.nsfs branch of the vfs/vfs.git tree.
Patches in the vfs-6.17.nsfs branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.17.nsfs
[1/1] uapi: export PROCFS_ROOT_INO
https://git.kernel.org/vfs/vfs/c/76fdb7eb4e1c
prev parent reply other threads:[~2025-07-10 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 13:21 Aleksa Sarai
2025-07-10 7:39 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710-visuell-joghurt-c76814720040@brauner \
--to=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®