From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tracing: Remove "__attribute__()" from the type field of event format
Date: Thu, 10 Jul 2025 09:53:27 -0400 [thread overview]
Message-ID: <20250710095327.69144489@batman.local.home> (raw)
In-Reply-To: <20250710224520.4eaf514db761ecaaee9bc1e1@kernel.org>
On Thu, 10 Jul 2025 22:45:20 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > And it doesn't free after allocation because it only does the
> > allocation for events that will never be freed. For modules, it
> > registers the allocated string so it will be freed on unload.
>
> What happen if the tracepoint in module has the __attribute__?
> (or enum etc?)
It adds the string to a linked list via add_str_to_module(). When the
module is unloaded, it searches the link list "module_strings" for all
the strings registered under that module and frees it.
See trace_module_remove_events().
-- Steve
next prev parent reply other threads:[~2025-07-10 13:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 11:54 [PATCH 0/2] tracing: Fix an event field filter issue Masami Hiramatsu (Google)
2025-07-08 11:54 ` [PATCH 1/2] tracing: Remove "__attribute__()" from the type field of event format Masami Hiramatsu (Google)
2025-07-09 1:06 ` kernel test robot
2025-07-09 16:51 ` Steven Rostedt
2025-07-10 13:47 ` Masami Hiramatsu
2025-07-09 17:11 ` Steven Rostedt
2025-07-10 13:45 ` Masami Hiramatsu
2025-07-10 13:53 ` Steven Rostedt [this message]
2025-07-11 1:44 ` Masami Hiramatsu
2025-07-11 5:37 ` Masami Hiramatsu
2025-07-11 16:03 ` Steven Rostedt
2025-07-12 11:45 ` Masami Hiramatsu
2025-07-12 14:37 ` Steven Rostedt
2025-07-12 15:13 ` Steven Rostedt
2025-07-14 14:14 ` Masami Hiramatsu
2025-07-14 14:32 ` Steven Rostedt
2025-07-08 11:54 ` [PATCH 2/2] tracing: Allocate field->type only if it needs to be sanitized Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710095327.69144489@batman.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®