mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Zihuan Zhang <zhangzihuan@kylinos.cn>
Cc: Christian Loehle <christian.loehle@arm.com>,
	xuewen.yan@unisoc.com, vincent.guittot@linaro.org,
	mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
	hongyan.xia2@arm.com, linux-kernel@vger.kernel.org,
	ke.wang@unisoc.com, di.shen@unisoc.com, xuewen.yan94@gmail.com,
	kprateek.nayak@amd.com, kuyo.chang@mediatek.com,
	juju.sung@mediatek.com, qyousef@layalina.io
Subject: Re: [PATCH v1] sched/uclamp: Exclude kernel threads from uclamp logic
Date: Thu, 10 Jul 2025 10:03:11 -0400	[thread overview]
Message-ID: <20250710100311.15cc55ce@batman.local.home> (raw)
In-Reply-To: <554d1da1-8b35-489c-973d-b5d5dba31403@kylinos.cn>

On Thu, 10 Jul 2025 08:55:28 +0800
Zihuan Zhang <zhangzihuan@kylinos.cn> wrote:

> The motivation behind this patch is to explore whether it’s worth 
> optimizing the uclamp hot path a bit further. Since kernel threads 
> typically don’t benefit from uclamp adjustments and often just inherit 
> default values (e.g., max=1024), we were wondering if skipping the 
> aggregation logic for such cases could slightly reduce overhead in some 
> workloads.
> 
> Of course, we want to be conservative and avoid breaking any legitimate 
> usage. So I’d love to hear your opinion — do you think it’s worthwhile 
> to pursue this kind of micro-optimization in uclamp, or is the potential 
> gain too marginal to justify the added logic?

My honest opinion is that if there's not a huge issue you are trying
to solve, then it's best to leave things as is. Tweaking this for
micro-optimizations usually end up causing a regression somewhere you
never expected.

-- Steve

  reply	other threads:[~2025-07-10 14:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03  9:14 Zihuan Zhang
2025-07-03  9:22 ` Christian Loehle
2025-07-03 10:07   ` Zihuan Zhang
2025-07-03 10:17     ` Christian Loehle
2025-07-10  0:47       ` Zihuan Zhang
2025-07-10  3:41         ` K Prateek Nayak
2025-07-15  6:05           ` Zihuan Zhang
2025-07-10  8:41         ` Christian Loehle
2025-07-15  5:54           ` Zihuan Zhang
2025-07-03 14:51     ` Steven Rostedt
2025-07-10  0:55       ` Zihuan Zhang
2025-07-10 14:03         ` Steven Rostedt [this message]
2025-07-15  5:59           ` Zihuan Zhang
2025-07-03  9:42 ` Xuewen Yan
2025-07-03 10:14   ` Zihuan Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250710100311.15cc55ce@batman.local.home \
    --to=rostedt@goodmis.org \
    --cc=bsegall@google.com \
    --cc=christian.loehle@arm.com \
    --cc=di.shen@unisoc.com \
    --cc=hongyan.xia2@arm.com \
    --cc=juju.sung@mediatek.com \
    --cc=juri.lelli@redhat.com \
    --cc=ke.wang@unisoc.com \
    --cc=kprateek.nayak@amd.com \
    --cc=kuyo.chang@mediatek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qyousef@layalina.io \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=xuewen.yan94@gmail.com \
    --cc=xuewen.yan@unisoc.com \
    --cc=zhangzihuan@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®