From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEF1BA32; Fri, 11 Jul 2025 07:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752217528; cv=none; b=g/Yi7gdztryge1QIhN2Srw649EhFVOJF5zh0H0SXMmlpR6iVKrsGKkEKmALZ9CZSL0iytHghh6mg+gKOgEdHmaYiZdeTxrEZqkdJfgxmS4isK2CSvgxV7nzwG8TjmdqH1mJoHrXfsYr3Sci967xbUoKHcJLZrfit92Rxw4FsNuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752217528; c=relaxed/simple; bh=Tm8gBt2rCLU6XAuJPmoqrUODd/ncKUQlIgBb8XS0mrM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F+vimgkZeoljZe/Ch5VeMdGvuid0J54EyGIMGtRqSSMfYZrKw0e+X+EUY1lWUvPzcnMKNe6/mX/X++TJ95JgGueWEBlMAnMIOBwOlIMzk2ay3uKz9AuMkRDKDgWOdlVbOH/gC4yXtHOwPz55jhQHX6PP5VBv3p+r4pm6yaDiSbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NPudT0N+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NPudT0N+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D676DC4CEED; Fri, 11 Jul 2025 07:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752217527; bh=Tm8gBt2rCLU6XAuJPmoqrUODd/ncKUQlIgBb8XS0mrM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NPudT0N+mxlarrk3a+ZdBPT0+i6l+ahSnKq8zT6TATF9ipiN09TgKZFu2CSWSVhGe Bu04DDZ1P6cZcV2fceK1CEKTt6UciKAtYRWlHk1h0HbZK9DUjjnZYrgCKX42YBE0fi 8QWkYWV+CENcSRehs0EIQ6oOEM/fAxWkLaTkzS/RUf0JRFPO2Fd5NTS+wvuPaeOP/z ZdcuuHCdsYq95WYpI1SX1qlYkmIKTbFgKiYq7o6JJQVCrd93+rUvFmxcns2LylWjIM kFvdR8zWqLae7Kp5ubDC5r80MoDWjnFi2DJ3pqDClBk1E7U0soVVMmo1TZSzh9VqI3 yGoPqB1xN9vdQ== Date: Fri, 11 Jul 2025 09:05:24 +0200 From: Maxime Ripard To: Brian Masney Cc: Philipp Zabel , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 9/9] drm/sun4i/sun4i_tcon_dclk: convert from round_rate() to determine_rate() Message-ID: <20250711-adorable-winged-petrel-3a55df@houat> References: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> <20250710-drm-clk-round-rate-v1-9-601b9ea384c3@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="zivgql4bvkmipb2l" Content-Disposition: inline In-Reply-To: <20250710-drm-clk-round-rate-v1-9-601b9ea384c3@redhat.com> --zivgql4bvkmipb2l Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 9/9] drm/sun4i/sun4i_tcon_dclk: convert from round_rate() to determine_rate() MIME-Version: 1.0 On Thu, Jul 10, 2025 at 01:43:10PM -0400, Brian Masney wrote: > The round_rate() clk ops is deprecated, so migrate this driver from > round_rate() to determine_rate() using the Coccinelle semantic patch > on the cover letter of this series. >=20 > Signed-off-by: Brian Masney > --- > drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c b/drivers/gpu/drm/su= n4i/sun4i_tcon_dclk.c > index 03d7de1911cd654f395ea85ad914588c4351f391..9b85bf512d4c81d0a12e8cf72= 6d5d5440343519c 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c > @@ -67,8 +67,8 @@ static unsigned long sun4i_dclk_recalc_rate(struct clk_= hw *hw, > return parent_rate / val; > } > =20 > -static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate, > - unsigned long *parent_rate) > +static int sun4i_dclk_determine_rate(struct clk_hw *hw, > + struct clk_rate_request *req) > { > struct sun4i_dclk *dclk =3D hw_to_dclk(hw); > struct sun4i_tcon *tcon =3D dclk->tcon; > @@ -77,7 +77,7 @@ static long sun4i_dclk_round_rate(struct clk_hw *hw, un= signed long rate, > int i; > =20 > for (i =3D tcon->dclk_min_div; i <=3D tcon->dclk_max_div; i++) { > - u64 ideal =3D (u64)rate * i; > + u64 ideal =3D (u64) req->rate * i; There shouldn't be any space after the cast. Once fixed, Acked-by: Maxime Ripard Maxime --zivgql4bvkmipb2l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaHC3tAAKCRAnX84Zoj2+ dobzAYCVVcAYpql/C3KJ0/eU3AQjFHauPT2cGsLWyUy+n9tXNFVQlKPXp/mq6Oxv JCN1APUBfj/Ztn6ba5LNjzk128VAzJlXRG36IVPExTtZksSGPtrh4+2d1RJgpCFc s5a30/t7DA== =Ftr2 -----END PGP SIGNATURE----- --zivgql4bvkmipb2l--